Apply point instancer matrix to all instances #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienblor
added
bug
sirpalee
approved these changes
Nov 17, 2021
sebastienblor
added a commit
that referenced
this pull request
Dec 6, 2021
* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 * Improving conversions between integer types. (#889) * Setting unsigned int parameters from int. (#887) * Adding more tests and conversions. (#887) * Passing render session to AiDeviceAutoSelect. (#903) Fixes #902 * Avoid calling AiRenderBegin when render is already running. (#901) Fixes #900 * Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908) Fixes #905 * Setting the returned version to default in the Sdr plugin. (#907) Fixes #906 * Using GetVolumeShader if native rprim is volume. (#920) Fixes #915 * Fix pointInstancer and prototypes visibilities (#916) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) (#882) Fixes #880 Fixes #772 * Updating master with changes from the fix branch (#886) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com> * Merging fix branch to master. (#894) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 * Improving conversions between integer types. (#889) * Setting unsigned int parameters from int. (#887) * Adding more tests and conversions. (#887) Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com> * Merging fix-7.0.0 to master (#909) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 * Improving conversions between integer types. (#889) * Setting unsigned int parameters from int. (#887) * Adding more tests and conversions. (#887) * Passing render session to AiDeviceAutoSelect. (#903) Fixes #902 * Avoid calling AiRenderBegin when render is already running. (#901) Fixes #900 * Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908) Fixes #905 * Setting the returned version to default in the Sdr plugin. (#907) Fixes #906 Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com> * Updating changelog and readme for Arnold 7. (#898) Fixes #897 * Fix pointInstancer and prototypes visibilities #458 * Updating changelog and readme for Arnold 7. (#898) Fixes #897 * Fix pointInstancer and prototypes visibilities #458 Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com> * Update tests for Arnold 7. (#922) (#923) * Don't write the default color manager node to usd #924 (#925) * Remap curves primvars (#926) * Remap curves primvars values #921 * Simplify calls to RemapCurvesVertexPrimvars #921 * Changing the default descriptor returned for AOVs. (#919) Fixes #918 * Apply point instancer matrix to all instances #928 (#929) Fixes #928 * Set product metadata. (#933) Fixes #932 * Add support for primvars on instances #944 (#948) Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com>
sebastienblor
added a commit
that referenced
this pull request
Dec 29, 2021
* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 * Improving conversions between integer types. (#889) * Setting unsigned int parameters from int. (#887) * Adding more tests and conversions. (#887) * Passing render session to AiDeviceAutoSelect. (#903) Fixes #902 * Avoid calling AiRenderBegin when render is already running. (#901) Fixes #900 * Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908) Fixes #905 * Setting the returned version to default in the Sdr plugin. (#907) Fixes #906 * Using GetVolumeShader if native rprim is volume. (#920) Fixes #915 * Fix pointInstancer and prototypes visibilities (#916) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) (#882) Fixes #880 Fixes #772 * Updating master with changes from the fix branch (#886) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com> * Merging fix branch to master. (#894) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 * Improving conversions between integer types. (#889) * Setting unsigned int parameters from int. (#887) * Adding more tests and conversions. (#887) Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com> * Merging fix-7.0.0 to master (#909) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) * Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. Fixes #880 Fixes #772 * Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885) * Support render tags in the render delegate. (#883) * Checking for render tags. * Tracking render tags for shapes. * Improving render tag tracking. * Interrupt before disabling nodes. * Renaming render tag handling functions and moving the core logic to a separate function. * Tracking the point instancer's render tag. Fixes #843 * Improving conversions between integer types. (#889) * Setting unsigned int parameters from int. (#887) * Adding more tests and conversions. (#887) * Passing render session to AiDeviceAutoSelect. (#903) Fixes #902 * Avoid calling AiRenderBegin when render is already running. (#901) Fixes #900 * Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908) Fixes #905 * Setting the returned version to default in the Sdr plugin. (#907) Fixes #906 Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com> * Updating changelog and readme for Arnold 7. (#898) Fixes #897 * Fix pointInstancer and prototypes visibilities #458 * Updating changelog and readme for Arnold 7. (#898) Fixes #897 * Fix pointInstancer and prototypes visibilities #458 Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com> * Update tests for Arnold 7. (#922) (#923) * Don't write the default color manager node to usd #924 (#925) * Remap curves primvars (#926) * Remap curves primvars values #921 * Simplify calls to RemapCurvesVertexPrimvars #921 * Changing the default descriptor returned for AOVs. (#919) Fixes #918 * Apply point instancer matrix to all instances #928 (#929) Fixes #928 * Set product metadata. (#933) Fixes #932 * Add support for primvars on instances #944 (#948) * Add render session to AiMsg calls #953 (#954) * Call AiResolveFilePath with procedural type #942 (#952) * Support USD 21.11 (#958) * Support USD 21.11 * Port schemas to USD 21.11 #957 * Fix build of usd_imaging with USD 21.11 #957 (#961) * Fix build of usd_imaging with USD 21.11 #957 * Mising ifdefs for older versions of USD #957 * Fix primvars on instanceable prims #944 (#965) * Extend the skinning baking interval to the surrounding integer frames #951 (#979) * Support curves UVs #975 (#977) * Light and shadow links default ignoreRoots to false #987 (#988) * Read USD builtin normals on meshes #962 (#986) * Read UsdLuxShadowAPI parameters #945 (#990) Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
We were ignoring the point Instancer primitive transform. With this PR, we now read its matrix (including eventual parent transforms), and apply it to all instances.
For motion blur, we were already just considering the instance xforms in the first and last keys. So I'm doing the same for the point instancer matrix as well.
Adding test_0185 with the scene provided in the ticket, it shows that the instances are 1 unit away in the Y axis
Issues fixed in this pull request
Fixes #928