feat: Add arguments for model parameters #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 95.41% 95.83% +0.42%
==========================================
Files 3 3
Lines 109 120 +11
==========================================
+ Hits 104 115 +11
Misses 5 5 ☔ View full report in Codecov by Sentry. |
carlosgjs
requested review from
RashmikaReddy,
cdcore09,
lsetiawan and
younesStrittmatter
and removed request for
younesStrittmatter
lsetiawan
reviewed
Dec 12, 2023
lsetiawan
reviewed
Dec 12, 2023
lsetiawan
reviewed
Dec 12, 2023
lsetiawan
approved these changes
Dec 12, 2023
Collaborator
lsetiawan
left a comment
lsetiawan
left a comment
There was a problem hiding this comment.
This PR looks good to me. I can't fully comment on actual mlflow implementation however. If all works, I believe it's good 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temperature, top_k and top_nparameters for both eval and generation pipelines (function -> CLI -> .yml workflow)