Skip to content

- Changed reference to AutoMapper to the range [11.0, 12.0) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2022

Conversation

micdah
Copy link
Contributor

@micdah micdah commented Jan 6, 2022

As a breaking change from version 11 onwards is dropped support for net461 it seems unreasonable to keep support for this framework in the extension also.

  • Switched targets to only support netstandard2.1

This is due to the fact that AutoMapper from version 11 has dropped support for net461 target.

Also removed optional dependencies, as package only target single framework now.

  • Switched targets for test project to net6.0

Mainly because AutoMapper 11 targets netstandard2.1 and this is not supported in netcoreapp2.1, also this target framework is no longer supported generally so updating seems like a good idea.

Secondly I work on an Apple Silicon machine, so bumping to something compatible with .Net 6 was required for me to be able to run the tests.

  • Updated using statements to target AutoMapper.Internal when necessary
  • Use new .Internal() rather than old .Advanced

As a breaking change from version `11` onwards is dropped support for `net461` it seems unreasonable to keep support for this framework in the extension also.

- Switched targets to only support `netstandard2.1`
This is due to the fact that AutoMapper from version `11` has dropped support for `net461` target.

Also removed optional dependencies, as package only target single framework now.

- Switched targets for test project to `net6.0`
Mainly because AutoMapper `11` targets `netstandard2.1` and this is not supported in `netcoreapp2.1`, also this target framework is no longer supported generally so updating seems like a good idea.

Secondly I work on an Apple Silicon machine, so bumping to something compatible with .Net 6 was required for me to be able to run the tests.

- Updated using statements to target `AutoMapper.Internal` when necessary
- Use new `.Internal()` rather than old `.Advanced`
@jbogard
Copy link
Member

jbogard commented Jan 6, 2022

To fix the build you'll need to add this step to pull in .NET 6:

https://github.com/AutoMapper/AutoMapper.Extensions.Microsoft.DependencyInjection/blob/master/.github/workflows/ci.yml#L22

@micdah
Copy link
Contributor Author

micdah commented Jan 6, 2022

To fix the build you'll need to add this step to pull in .NET 6:

https://github.com/AutoMapper/AutoMapper.Extensions.Microsoft.DependencyInjection/blob/master/.github/workflows/ci.yml#L22

Sorry, I'm an idiot forgot to include with with: part 🤦‍♂️

@jbogard jbogard merged commit 27a9d01 into AutoMapper:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants