Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainnet audit base branch #1155

Closed
wants to merge 39 commits into from
Closed

Mainnet audit base branch #1155

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d09627d
add CID field to entries
topocount Jun 13, 2019
3a383fe
add test for CID length check
topocount Jun 13, 2019
e78fab6
convert contract to map solely to a CID
topocount Jun 15, 2019
1009a13
[chore] Pin dependencies having smart contracts
ottodevs Jun 28, 2019
6fc7db1
[chore] Update @aragon/test-helpers
ottodevs Jun 28, 2019
8e1dc43
[hotfix] Correct dangerous git clean to preserve new files and deleti…
ottodevs Jun 28, 2019
1301dfe
Clean rewards .gitignore and missing files
ottodevs Jun 28, 2019
daa2033
Clean rewards .soliumignore extra line
ottodevs Jun 28, 2019
fee8f3a
Simplify and clean rewards solidity coverage conf
ottodevs Jun 28, 2019
277ed5a
Modernize rewards solium config -> ethlint
ottodevs Jun 28, 2019
ac1e9d5
Rewards use ganache-cli.sh from aragon instead
ottodevs Jun 28, 2019
c3a1c00
[chore] Correct rewards dependencies:
ottodevs Jun 28, 2019
75bcb44
Add local mineBlock test-helper
ottodevs Jun 28, 2019
521b486
Consolidate test contracts imports and remove unused migrations
ottodevs Jun 28, 2019
e4b7d63
Use common @aragon/os truffle config
ottodevs Jun 28, 2019
34d0e34
Test file fixes:
ottodevs Jun 28, 2019
34dee62
[contract] Lock pragma
ottodevs Jun 28, 2019
e3dbd3d
[contract] Fix imports (isContract is inherited)
ottodevs Jun 28, 2019
ca0ed50
[contract] Remove isContract, already inherited
ottodevs Jun 28, 2019
ab21608
[contract] Sort, comment and annotate initialize()
ottodevs Jun 28, 2019
3e725c6
[contract] Combine rewardAmount calculation
ottodevs Jun 28, 2019
95784bb
[contract] Use new calculateRewardAmount()
ottodevs Jun 28, 2019
8ac7fc0
[contract] Refactor claimReward():
ottodevs Jun 28, 2019
a186c26
[contract] Refactor newReward():
ottodevs Jun 28, 2019
441881a
[contract] Fix spacing
ottodevs Jun 28, 2019
e4ccbe2
[chore] Lint contracts to make CI pass
ottodevs Jun 28, 2019
d8ab505
Apply gas optimizations
ottodevs Jun 28, 2019
c4797f4
Review license and text
ottodevs Jun 28, 2019
417159a
Fix missed optimized order in struct
ottodevs Jun 28, 2019
76c5d29
Improve comments for functions - part 1
ottodevs Jun 28, 2019
8096625
Complete the full commenting for the contract
ottodevs Jun 28, 2019
e9bb6bf
Add additional members comments
ottodevs Jun 28, 2019
534cdf9
Fix typo on documented param
ottodevs Jun 28, 2019
4f3f11c
change author to Autark Labs
topocount Jul 1, 2019
0a52280
Address MixedBytes interim audit findings and comments
topocount Jul 16, 2019
48540a8
add check for zero occurrences
topocount Jul 18, 2019
496530e
Merge branch 'dev' into mainnet-audit
topocount Aug 20, 2019
40633c3
update eslint to handle solidity test files
topocount Aug 23, 2019
1002f74
Merge branch 'dev' into mainnet-audit
chadoh Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean rewards .gitignore and missing files
  • Loading branch information
@ottodevs
ottodevs committed Aug 5, 2019
commit 1301dfe28783b17c504091a09ed2705b5e92b1fe
11 changes: 6 additions & 5 deletions apps/rewards/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
// TODO: Some cleaning
node_modules
build
.cache

# dependencies
/node_modules

# testing
/coverage
coverage.json

# production
/build

# development
.cache

# misc
.DS_Store
.env.local
Expand All @@ -27,3 +26,5 @@ yarn-error.log*
/public/aragon-ui
/public/script.js
/public/script.map

package-lock.json