Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainnet audit base branch #1155

Closed
wants to merge 39 commits into from
Closed

Mainnet audit base branch #1155

wants to merge 39 commits into from

Conversation

ottodevs
Copy link
Member

@ottodevs ottodevs commented Aug 5, 2019

This PR will contain every change from the audits to have a final review of the changes for each app combined to be ready for mainnet.

Depends on mainnet audit changes from:

topocount and others added 30 commits August 5, 2019 03:53
@topocount @ottodevs
add CID field to entries
d09627d
@topocount @ottodevs
add test for CID length check
3a383fe
@topocount @ottodevs
convert contract to map solely to a CID
e78fab6 
- remove entry struct
- remove all name-related require lines
- update tests accordingly
@ottodevs
[chore] Pin dependencies having smart contracts
1009a13
@ottodevs
[chore] Update @aragon/test-helpers
6fc7db1
@ottodevs
[hotfix] Correct dangerous git clean to preserve new files and deleti…
8e1dc43 
…ng only .gitignored files on npm run clean and npm run clean:build
@ottodevs
Clean rewards .gitignore and missing files
1301dfe
@ottodevs
Clean rewards .soliumignore extra line
daa2033
@ottodevs
Simplify and clean rewards solidity coverage conf
fee8f3a
@ottodevs
Modernize rewards solium config -> ethlint
277ed5a
@ottodevs
Rewards use ganache-cli.sh from aragon instead
ac1e9d5
@ottodevs
[chore] Correct rewards dependencies:
c3a1c00 
- Add missing dependencies
- Make rewards capable to run in isolation
- ganache-cli.sh still needs a path change on that case
- Remove unused dependencies (react-motion)
- Remove @tps/test-helpers dep
@ottodevs
Add local mineBlock test-helper
75bcb44
@ottodevs
Consolidate test contracts imports and remove unused migrations
521b486
@ottodevs
Use common @aragon/os truffle config
e4b7d63
@ottodevs
Test file fixes:
34d0e34 
- Stop using @tps/test-helpers, use @aragon instead, or local if needed
- Consolidate inline helper functions
- Refactor artifacts requirements
- Refactor before hook and modernize to follow modern trends
- Remove unused variables and functions
- Fix typos
- Lint file
@ottodevs
[contract] Lock pragma
34dee62
@ottodevs
[contract] Fix imports (isContract is inherited)
e3dbd3d
@ottodevs
[contract] Remove isContract, already inherited
ca0ed50
@ottodevs
[contract] Sort, comment and annotate initialize()
ab21608
@ottodevs
[contract] Combine rewardAmount calculation
3e725c6
@ottodevs
[contract] Use new calculateRewardAmount()
95784bb
@ottodevs
[contract] Refactor claimReward():
8ac7fc0 
- Sort to prevent reentrancy
- Use inherited TimeHelpers functions
- Lint spacing
- Extract transfer reward logic to new private function
@ottodevs
[contract] Refactor newReward():
a186c26 
- Sort to prevent reentrancy
- Add additional comments
- Fix typos
- Use MiniMeToken instance instead of address of referenceToken
- Make guards cleaner, merge `if` condition into the guard
@ottodevs
[contract] Fix spacing
441881a
@ottodevs
[chore] Lint contracts to make CI pass
e4ccbe2
@ottodevs
Apply gas optimizations
d8ab505
@ottodevs
Review license and text
c4797f4
@ottodevs
Fix missed optimized order in struct
417159a
@ottodevs
Improve comments for functions - part 1
76c5d29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.747% when pulling 48540a8 on mainnet-audit into 7c32597 on dev.

topocount and others added 3 commits August 20, 2019 10:32
@topocount
Merge branch 'dev' into mainnet-audit
496530e
@topocount
update eslint to handle solidity test files
40633c3
@chadoh
Merge branch 'dev' into mainnet-audit
1002f74 
* dev: (39 commits)
  Projects: revert to old aragonUI version
  Projects: mv AppTitleButton
  Dot Voting/date-fns: use v2 formatting strings
  Upgrade date fns (#1188)
  upgrade Rewards ADS UI (#1187)
  Aragon DS upgrade: addressbook (#1156)
  Revert Rewards & Projects to previous aragonUI
  Dot Voting: fix issues found during QA
  Dot Voting/CastVote: fix prop type
  Revert "[DEV] rm pre-commit lint"
  Dot Voting: mv totalSupport calc to VotingResults
  Dot Voting/VoteDetails: mv Participation
  Dot Voting/CastVote: rm tokenData; keep userBalance
  Dot Voting: define tokenContract in CastVote
  Dot Voting: mv CastVote to own file
  Dot Voting/VoteDetails: mv VoteEnact & VotingResults
  Add a minimal EMPTY_ROLE to Discussions - This is needed to be considered an actual Aragon app by the Kernel - Reference: https://hack.aragon.org/docs/cli-dao-commands#dao-install
  Remove partial ACL guards on discussions:
  Discussions: fix typos in README examples
  Dot voting demo fixes (#1176)
  ...
@chadoh chadoh mentioned this pull request Sep 2, 2019
Merged
@ottodevs ottodevs added app: address book app: allocations app: dot voting app: projects app: rewards contracts Involves changes to solidity files testing This issue only requires generation of tests labels Oct 2, 2019
@topocount
Copy link
Collaborator

Closing since the audit is wrapping up

@topocount topocount closed this Oct 22, 2019
This was referenced Oct 23, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app: address book app: allocations app: dot voting app: projects app: rewards contracts Involves changes to solidity files testing This issue only requires generation of tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ottodevs @coveralls @topocount @chadoh