Skip to content

fix: fix circular import caused by type annotations #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Oct 28, 2025
Merged

fix: fix circular import caused by type annotations #111

merged 63 commits into from
Oct 28, 2025

Conversation

@marius-mather
Copy link
Collaborator

@marius-mather marius-mather commented Oct 28, 2025

No description provided.

@marius-mather
refactor: rename user_is_admin -> user_is_general_admin to make purpo…
15477f3 
…se clearer
@marius-mather
refactor: rename SessionUser.is_admin SessionUser.is_biocommons_admin
1099540
@marius-mather
feat: add group/platform admin checks for the user
d517f73
@marius-mather
refactor: rename get_current_user -> get_session_user for clarity
f0c02bf
@marius-mather
refactor: add DB checks to user_is_general_admin check
ff75d43
@marius-mather
test: update tests to allow for updated admin check
6d5b1bf
@marius-mather
test: add tests of user_is_general_admin check
6bbdb7a
@marius-mather
test: add tests of DB admin checks
1aab11c
@marius-mather
refactor: update is-admin endpoint to is-general-admin
ed90978
@marius-mather
refactor: update tests of is-admin check
2c0dba4
@marius-mather
refactor: move user permissions to a new module
7fb258b
@marius-mather
feat: add check for is_biocommons_admin and a new router for biocommo…
f577d7d 
…ns admin routes
@marius-mather
chore: add biocommons_admin router to main app
aaa1a22
@marius-mather
refactor: start moving routes to /biocommons-admin
3ea3f68
@marius-mather
refactor: simplify creating groups in the API
e3f868f
@marius-mather
refactor: lookup methods for roles and platforms
5d3ad88
@marius-mather
refactor: rework group/role/platform creation endpoints
cbce2f9
@marius-mather
test: move biocommons-admin tests to a dedicated module
054e08f
@marius-mather
test: fix mocks in user tests
ca90616
@marius-mather
Merge remote-tracking branch 'origin/main' into feature/role-permissions
2c4f193
@marius-mather
feat: add is_admin check for platform model
6838b2f
@marius-mather
refactor: rework UserQueryParams to add group/platform admin checks, …
71a6946 
…use it in all endpoints
@marius-mather
test: update tests of get_users to include platform-specific users
d721326
@marius-mather
test: test group or platform admin access
fdf7252
@marius-mather
feat: more permissions checks that can be applied to endpoints
613badf
@marius-mather
refactor: move 'get_or_404' checks into models
5252ffb
@marius-mather
refactor: add permission checks to admin endpoints
6cc4e13
@marius-mather
refactor: renamed get_for_admin_roles -> get_from_admin_roles
304ce96
@marius-mather
refactor: move shared param types to schemas to avoid circular import
b6fd0ad
@marius-mather
fix: should use _or_404 for getting the group
16dcb81
uwwint and others added 25 commits October 16, 2025 20:05
@uwwint
Merge branch 'main' into feature/role-permissions
5fd68f7
@uwwint
fix: sync platform roles to db, response typing
bbda631 
test: increase test coverate to 100%
@marius-mather
fix: undefiend role name in error message
a75510c
@marius-mather
docs: docstring fixes
c63a41c
@marius-mather
Merge branch 'feature/role-permissions' of github.com:AustralianBioCo…
541a27d 
…mmons/aai-backend into feature/role-permissions
@marius-mather
docs: update DB diagram
3ce3997
@marius-mather
Merge remote-tracking branch 'origin/main' into feature/role-permissions
29c27c7
@marius-mather
feat: add schemas for user profile data
ba4ab49
@marius-mather
feat: add an endpoint for fetching profile data for current user
14f885b
@marius-mather
fix: need to get user's name from Auth0 data
00f0ab4
@marius-mather
test: test getting profile data from DB and Auth0 data
16aa1aa
@marius-mather
test: test profile endpoint
848e5b8
@marius-mather
refactor: cache the Auth0 management token - fetching it is slow
cb5f863
@marius-mather
feat: add a dependency that allows looking up Auth0 userinfo endpoint…
4fdeb3f 
… directly
@marius-mather
refactor: update profile endpoint to use userinfo lookup
e2e65ee
@marius-mather
test: update tests of profile data
1e07c53
@marius-mather
fix: exclude revoked memberships from user profile data
14f5c47
@marius-mather
test: check that revoked groups/platforms are excluded from profile data
f78116b
@marius-mather
Merge remote-tracking branch 'origin/main' into feature/user-profile-api
7ba8d56
@marius-mather
refactor: set up new cache before replacing the existing one
261fd48 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@marius-mather
fix: use AsyncClient to get userinfo
1e76963 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@marius-mather
test: fix override for get_auth0_user_info
5e5d43d
@marius-mather
test: different method to override userinfo lookup
dcb791a
@marius-mather
fix: fix circular import by only importing db models for type checking
cb7f2b2
@marius-mather
Merge remote-tracking branch 'origin/main' into feature/user-profile-api
1aa73df
@amandazhuyilan amandazhuyilan self-requested a review October 28, 2025 05:49
@marius-mather marius-mather merged commit daf0687 into main Oct 28, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Open
@amandazhuyilan amandazhuyilan deleted the feature/user-profile-api branch November 24, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amandazhuyilan amandazhuyilan amandazhuyilan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marius-mather @amandazhuyilan @onesandzeroes @uwwint