-
Notifications
You must be signed in to change notification settings - Fork 122
[PAY-3531] Add geo-location to download logging #10118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a1e8a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rickyrombo
approved these changes
Oct 18, 2024
faridsalau
reviewed
Oct 18, 2024
faridsalau
reviewed
Oct 18, 2024
faridsalau
approved these changes
Oct 18, 2024
schottra
added a commit
that referenced
this pull request
Oct 18, 2024
…_tips * origin/main: [PAY-3531] Add geo-location to download logging (#10118) [QA-1737] Center user links in collection and user cards (#10122) [C-5197] Fix native comment show more/less collapse (#10121) [C-5212] Open comment drawer from empty state (#10117) Audius Protocol v0.7.15 Fix discovery comment notifications (#10119) [PAY-3522] Hides keyboard when opening purchase drawer from a DM (#10116) [C-5183, C-5190] Refactor comment notifications (#10092) Re-land changes to fix RN on xcode 16 (#10108) [QA-1773] Fix corner overflow on GiantTrackTile (#10110) [C-5209] Missing $ on downloads button (#10111)
schottra
added a commit
that referenced
this pull request
Oct 21, 2024
* origin/main: (312 commits) Drop chromatic (#10128) Audius Client (Web and Mobile) v1.5.104 core 1s block times (#10127) Fix comment notification data (#10123) chat_allowed UDF uses user_tips instead of aggregate table. (#10120) [PAY-3531] Add geo-location to download logging (#10118) [QA-1737] Center user links in collection and user cards (#10122) [C-5197] Fix native comment show more/less collapse (#10121) [C-5212] Open comment drawer from empty state (#10117) Audius Protocol v0.7.15 Fix discovery comment notifications (#10119) [PAY-3522] Hides keyboard when opening purchase drawer from a DM (#10116) [C-5183, C-5190] Refactor comment notifications (#10092) Re-land changes to fix RN on xcode 16 (#10108) [QA-1773] Fix corner overflow on GiantTrackTile (#10110) [C-5209] Missing $ on downloads button (#10111) Drop Android InputAccessoryView (#10107) Fix get new blasts endpoint sql error (#10109) [C-5189] Fix mobile web skeletons (#10106) [C-5201] Fix comments not showing as pinned (#10105) ...
audius-infra
pushed a commit
that referenced
this pull request
Oct 21, 2024
samgutentag
pushed a commit
that referenced
this pull request
Nov 1, 2024
samgutentag
pushed a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add geo location to track download
There are lots of ways this could be done with a larger lift that I think we should consider at a future time.
For now, leverage the fact that things are coming from the client and attach metadata to the entity mgr transaction.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.