[C-5183, C-5190] Refactor comment notifications #10092
Conversation
|
dylanjeffers
changed the title
| @@ -1,57 +0,0 @@ | |||
| create or replace function handle_comment_mention() returns trigger as $$ | |||
There was a problem hiding this comment.
i think you'd still want the to replace the existing function with a no-op? did @stereosteve say differently?
There was a problem hiding this comment.
@isaacsolo should have let you know that this was what steve said :) just need the migration to explicitly remove the triggers
|
|
||
| if new.is_delete is false then | ||
| select tracks.owner_id | ||
| into entity_owner_id |
There was a problem hiding this comment.
these variable declarations can be cleaned up as well
| raise IndexingValidationError( | ||
| f"parent_comment_id {parent_comment_id} must be a number" | ||
| ) | ||
| if parent_comment_id is not None: |
There was a problem hiding this comment.
nit could also just be if parent_comment_id same for cases below
[528102b] Fix discovery comment notifications (#10119) Dylan Jeffers [52166e8] [C-5183, C-5190] Refactor comment notifications (#10092) Dylan Jeffers [40cdc8f] Fix get new blasts endpoint sql error (#10109) Reed [761524e] Various comment reply fixes (muting/reporting) (#10096) JD Francis [e488758] [C-5203] Fix comment unpin (#10102) Dylan Jeffers [178f051] Update UDR to match specification (#10098) Raymond Jacobson
…_tips * origin/main: [PAY-3531] Add geo-location to download logging (#10118) [QA-1737] Center user links in collection and user cards (#10122) [C-5197] Fix native comment show more/less collapse (#10121) [C-5212] Open comment drawer from empty state (#10117) Audius Protocol v0.7.15 Fix discovery comment notifications (#10119) [PAY-3522] Hides keyboard when opening purchase drawer from a DM (#10116) [C-5183, C-5190] Refactor comment notifications (#10092) Re-land changes to fix RN on xcode 16 (#10108) [QA-1773] Fix corner overflow on GiantTrackTile (#10110) [C-5209] Missing $ on downloads button (#10111)
Description
After realizing some limitations with db-trigger notifications, I completely reworked notifications to be generated in the indexing layer itself. This made things ALOT more complicated, but was a necessary evil. Added a ton of test coverage.