-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix info link for service instances tooltip #2750
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright The Athenz Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| describe('services screen tests', () => { | ||
| it('when clicking help tooltip link, it should open a tab with athenz guide', async () => { | ||
| // open browser | ||
| await browser.newUser(); | ||
| await browser.url(`/`); | ||
| // select domain | ||
| let domain = 'athenz.dev.functional-test'; | ||
| let testDomain = await $(`a*=${domain}`); | ||
| await browser.waitUntil(async () => await testDomain.isClickable()); | ||
| await testDomain.click(); | ||
|
|
||
| // open Services | ||
| let servicesButton = await $('div*=Services'); | ||
| await browser.waitUntil(async () => await servicesButton.isClickable()); | ||
| await servicesButton.click(); | ||
|
|
||
| // add service | ||
| const serviceName = 'tooltip-link-test-service'; | ||
| let addServiceButton = await $('button*=Add Service'); | ||
| await addServiceButton.click(); | ||
| let serviceNameInput = await $('input[id="service-name"]'); | ||
| await serviceNameInput.addValue(serviceName); | ||
| let submitButton = await $('button*=Submit'); | ||
| await submitButton.click(); | ||
|
|
||
| // navigate to tooltip | ||
| let serviceInstancesButton = await $(`.//*[local-name()="svg" and @id="${'view-instances-' + serviceName}"]`); | ||
| await serviceInstancesButton.click(); | ||
| // open tooltip | ||
| let instanceHelpTooltipButton = await $(`.//*[local-name()="svg" and @id="instances-help-tooltip"]`); | ||
| await instanceHelpTooltipButton.click(); | ||
| // click athenz guide link | ||
| await browser.pause(1000); // wait a little so that onclick function is assigned to the anchor | ||
| let athenzGuideAnchor = await $('a*=here'); | ||
| await athenzGuideAnchor.click(); | ||
| await browser.pause(1000); // Just to ensure the new tab opens | ||
| // switch to opened tab | ||
| const windowHandles = await browser.getWindowHandles(); | ||
| expect(windowHandles.length).toBeGreaterThan(1); | ||
| await browser.switchToWindow(windowHandles[1]); | ||
| // verify the URL of the new tab | ||
| const url = await browser.getUrl(); | ||
| expect(url).toContain('athenz-guide'); | ||
| }); | ||
|
|
||
| // after - runs after the last test in order of declaration | ||
| after(async() => { | ||
| // open browser | ||
| await browser.newUser(); | ||
| await browser.url(`/`); | ||
| // select domain | ||
| let domain = 'athenz.dev.functional-test'; | ||
| let testDomain = await $(`a*=${domain}`); | ||
| await browser.waitUntil(async () => await testDomain.isClickable()); | ||
| await testDomain.click(); | ||
|
|
||
| // open Services | ||
| let servicesButton = await $('div*=Services'); | ||
| await browser.waitUntil(async () => await servicesButton.isClickable()); | ||
| await servicesButton.click(); | ||
|
|
||
| // delete service created for the test | ||
| let serviceDeleteButton = await $('.//*[local-name()="svg" and @id="delete-service-tooltip-link-test-service"]'); | ||
| await serviceDeleteButton.click(); | ||
| let modalDeleteButton = await $('button*=Delete'); | ||
| await modalDeleteButton.click(); | ||
| }); | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekhar1996 is this what you meant to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes