Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix info link for service instances tooltip #2750

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ArtjomsPorss
Copy link
Contributor

@ArtjomsPorss ArtjomsPorss commented Oct 1, 2024

Description

Fixes info link to point to athenz guide where before it used to open a blank tab.

  • Main change is in the static.js and dynamic.js where domainName and serviceName were incorrectly referenced.
  • added a file with a functional test
  • fixed dynamic.test.js and static.test.js
  • rest of the changes are to support ease of writing functional test
  • recreated snapshots

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Signed-off-by: aporss <art.porss@yahooinc.com>
target: '_blank',
dynamic : {
description:
'Here you can see instances which are running with this service identity',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrasekhar1996 is this what you meant to change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@ArtjomsPorss ArtjomsPorss marked this pull request as ready for review October 3, 2024 14:15
@abvaidya abvaidya merged commit 8040a70 into AthenZ:master Oct 3, 2024
2 checks passed
havetisyan added a commit that referenced this pull request Oct 7, 2024
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
havetisyan added a commit that referenced this pull request Oct 7, 2024
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants