Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix refresh role and group history displays no history #2739

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

ArtjomsPorss
Copy link
Contributor

@ArtjomsPorss ArtjomsPorss commented Sep 23, 2024

Description

When a particular Roles or Groups history page is refreshed - it displays no history.
The change fixes this bug.

  • changed reducers - payload expansion for some reason was not assigning values, so assigning from payload directly to new state.
  • added functional tests for group and roles screens

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Screen.Recording.2024-09-23.at.16.43.15.mov

Signed-off-by: aporss <art.porss@yahooinc.com>
@ArtjomsPorss ArtjomsPorss marked this pull request as ready for review September 23, 2024 16:02
@havetisyan havetisyan merged commit dd281b3 into AthenZ:master Sep 29, 2024
2 checks passed
havetisyan added a commit that referenced this pull request Sep 30, 2024
…from master to the jett-12 branch

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
havetisyan added a commit that referenced this pull request Sep 30, 2024
…from master to the jett-12 branch (#2749)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants