Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable advanced settings for delegated roles during role creation or editing #2733

Merged
merged 1 commit into from
Sep 23, 2024
Merged

disable advanced settings for delegated roles during role creation or editing #2733

merged 1 commit into from
Sep 23, 2024

Conversation

ArtjomsPorss
Copy link
Contributor

Description

  • Disabled advanced settings except description during role creation.
  • Disabled settings except description on role editing screen.
  • Added functional test.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots

Role Creation - Advanced settings except Description are disabled:

Screenshot 2024-09-16 at 14 44 39 Screenshot 2024-09-16 at 14 45 11

Role Settings editing - All settings except Description are disabled:

Screenshot 2024-09-16 at 14 46 01 Screenshot 2024-09-16 at 14 46 20

@ArtjomsPorss ArtjomsPorss marked this pull request as ready for review September 16, 2024 15:54
@ArtjomsPorss
disable advanced settings for delegated roles during role creation or…
feb5fc0 
… editing

Signed-off-by: aporss <art.porss@yahooinc.com>
@havetisyan havetisyan merged commit d0dd183 into AthenZ:master Sep 23, 2024
2 checks passed
havetisyan added a commit that referenced this pull request Sep 30, 2024
@havetisyan
merge #2747, #2746, #2739, #2742, #2740, #2743, #2744, #2737 and #2733 …
6425ab2 
…from master to the jett-12 branch

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
@havetisyan havetisyan mentioned this pull request Sep 30, 2024
Merged
3 tasks
havetisyan added a commit that referenced this pull request Sep 30, 2024
@havetisyan
merge #2747, #2746, #2739, #2742, #2740, #2743, #2744, #2737 and #2733 …
9ce6a10 
…from master to the jett-12 branch (#2749)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandrasekhar1996 chandrasekhar1996 chandrasekhar1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtjomsPorss @chandrasekhar1996 @havetisyan