Skip to content

Comments

Removed shared_lib flag when running the model#5

Merged
AlfredMayhew merged 1 commit intoAtChem:masterfrom
AlfredMayhew:shared-lib-changes
Oct 22, 2025
Merged

Removed shared_lib flag when running the model#5
AlfredMayhew merged 1 commit intoAtChem:masterfrom
AlfredMayhew:shared-lib-changes

Conversation

@AlfredMayhew
Copy link
Collaborator

Given recent changes to the location of the shared lib (AtChem/AtChem2#535), the shared_lib flag is no longer needed when calling the model, and raises an error. I have removed this to allow models to run correctly.

@AlfredMayhew
Copy link
Collaborator Author

@rs028 , I will merge this unless I'm forgetting something? All I needed to do was remove the shared_lib flag when executing the model, right? I already specify the model/configuration path during the build step, and the --model flag during model execution.
I've tested it and it seems to work.

@rs028
Copy link

rs028 commented Oct 22, 2025

Yes, I think so. Keep in mind this is an intermediate step and we want to fully move those files out of configuration, which means shared_lib (or something similar) will be re-introduced (see AtChem/AtChem2#539), but since we may decide to use flags for the build script we can do all in one go (no need to break things more than once!).

@AlfredMayhew AlfredMayhew merged commit b531b12 into AtChem:master Oct 22, 2025
@AlfredMayhew AlfredMayhew deleted the shared-lib-changes branch October 22, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants