Skip to content

remove experimental bigint v8 flags #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2021
Merged

remove experimental bigint v8 flags #2076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5174b41
remove experimental-bigint v8 flags
MaxGraey Sep 15, 2021
c27673b
remove from all other places
MaxGraey Sep 15, 2021
f08dfd4
remov mut globals from ci
MaxGraey Sep 15, 2021
0aacf54
revert
MaxGraey Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove experimental-bigint v8 flags
  • Loading branch information
@MaxGraey
MaxGraey committed Sep 15, 2021
commit 5174b41d5da5ffa1d66af6c2d4a46da9632dc705
2 changes: 0 additions & 2 deletions tests/compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,15 +342,13 @@ function runTest(basename) {
}
let rtracedBuffer = stdout.toBuffer();
const instantiateRtrace = section("instantiate rtrace");
v8.setFlagsFromString("--experimental-wasm-bigint");
if (!testInstantiate(basename, rtracedBuffer, glue, stderr, config.asc_wasi)) {
failed = true;
failedTests.add(basename);
instantiateRtrace.end(FAILURE);
} else {
instantiateRtrace.end(SUCCESS);
}
v8.setFlagsFromString("--no-experimental-wasm-bigint");
});
});
if (failed) return 1;
Expand Down
7 changes: 2 additions & 5 deletions tests/features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"mutable-globals": {
},
"bigint-integration": {
},
"nontrapping-f2i": {
"asc_flags": [
"--enable nontrapping-f2i"
Expand Down Expand Up @@ -40,11 +42,6 @@
"--experimental-wasm-gc"
]
},
"bigint-integration": {
"v8_flags": [
"--experimental-wasm-bigint"
]
},
"exception-handling": {
"asc_flags": [
"--enable exception-handling"
Expand Down