Skip to content

remove experimental bigint v8 flags #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
run: npm run clean
- name: Test experimental features
env:
ASC_FEATURES: mutable-globals,threads,reference-types,bigint-integration,gc
ASC_FEATURES: threads,reference-types,bigint-integration,gc
run: |
npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads std-wasi/process std-wasi/crypto
test-runtimes:
Expand Down
2 changes: 0 additions & 2 deletions tests/compiler.js
Original file line number Diff line number Diff line change
Expand Up @@ -342,15 +342,13 @@ function runTest(basename) {
}
let rtracedBuffer = stdout.toBuffer();
const instantiateRtrace = section("instantiate rtrace");
v8.setFlagsFromString("--experimental-wasm-bigint");
if (!testInstantiate(basename, rtracedBuffer, glue, stderr, config.asc_wasi)) {
failed = true;
failedTests.add(basename);
instantiateRtrace.end(FAILURE);
} else {
instantiateRtrace.end(SUCCESS);
}
v8.setFlagsFromString("--no-experimental-wasm-bigint");
});
});
if (failed) return 1;
Expand Down
7 changes: 2 additions & 5 deletions tests/features.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"mutable-globals": {
},
"bigint-integration": {
},
"nontrapping-f2i": {
"asc_flags": [
"--enable nontrapping-f2i"
Expand Down Expand Up @@ -40,11 +42,6 @@
"--experimental-wasm-gc"
]
},
"bigint-integration": {
"v8_flags": [
"--experimental-wasm-bigint"
]
},
"exception-handling": {
"asc_flags": [
"--enable exception-handling"
Expand Down