Skip to content

fix: Fix negative inputs of Math.acosh #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2021
Merged

fix: Fix negative inputs of Math.acosh #1876

merged 3 commits into from
Jun 1, 2021

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented May 30, 2021 •
edited
Loading

Some negative inputs for acosh may produce non-NaN values while all range x < 1 should always return NaN. This PR fix this.

Thanks to @Yaffle for finding this edge case

  • I've read the contributing guidelines

@MaxGraey MaxGraey changed the title fix: Fix negative inputs of acosh fix: Fix negative inputs of Math.acosh May 30, 2021
@dcodeIO
Copy link
Member

dcodeIO commented May 30, 2021

Is it expected that musl may eventually fix this in a different way? If so, perhaps a comment? :)

dcodeIO
dcodeIO approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@MaxGraey MaxGraey merged commit 8611261 into AssemblyScript:master Jun 1, 2021
@MaxGraey MaxGraey deleted the fix-math-funcs branch June 1, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO