Reference feature in not implemented diagnostic #1295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #1294 this also adds the respective missing feature to
Not implemented
diagnostics, looking likewhile converting some of the diagnostics back to
assert
s, but only where hitting that code path would indicate a bug that must be fixed anyway and a diagnostic wouldn't be helpful, i.e. "Expression kind X cannot be looked up / resolved / compiled because someone forgot to implement it".fixes #1294