Skip to content

Reference feature in not implemented diagnostic #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2020
Merged

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented May 26, 2020

As a follow-up to #1294 this also adds the respective missing feature to Not implemented diagnostics, looking like

AS100: Not implemented: ref.eq
AS100: Not implemented: Closures
AS100: Not implemented: Exceptions

while converting some of the diagnostics back to asserts, but only where hitting that code path would indicate a bug that must be fixed anyway and a diagnostic wouldn't be helpful, i.e. "Expression kind X cannot be looked up / resolved / compiled because someone forgot to implement it".

fixes #1294

Copy link
Contributor

@DuncanUszkay1 DuncanUszkay1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dcodeIO
Copy link
Member Author

dcodeIO commented May 26, 2020

I have no idea why this is failing now as it didn't touch anything essential, and why GH Actions is showing output in fantasy order :(

@MaxGraey
Copy link
Member

closure [stderr mismatch]. I guess need update some parser's fixture?

@DuncanUszkay1
Copy link
Contributor

closure [stderr mismatch]. I guess need update some parser's fixture?

Oh yeah that makes sense, the stderr is hardcoded into the test json files, they'll have to be updated

@dcodeIO
Copy link
Member Author

dcodeIO commented May 26, 2020

Ah, I see, thanks! My local ts-node cache didn't update again, explaining why I wasn't able to reproduce locally.

@dcodeIO dcodeIO merged commit 4139a74 into master May 27, 2020
@dcodeIO dcodeIO deleted the not-implemented branch June 11, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants