Add argument to not implemented error message #1294
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1286
Right now
Not Implemented
accepts no arguments, but it'd be nice if it also included a string which stated what exactly isn't implemented for cases when the range alone doesn't suffice.Here I've just added the argument for the preexisting message, however I could also make an additional diagnostic message which has the argument so that we don't have to go fix every use of not implemented. The only issue with that is that we'd need a different diagnostic code, and based on the fact that they've been manually specified I'm assuming there's some special meaning behind the selected codes.
Without passing the argument:
ERROR AS100: Not implemented: {0}
When passing the argument:
ERROR AS100: Not implemented: Try Statements
So we'd likely need to go update all the current Not implemented error calls for this to go in.
Would love to have this for the closures PR so that I can make the Not implemented errors more clear
Thoughts?