Skip to content

Add argument to not implemented error message #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DuncanUszkay1
Copy link
Contributor

Issue: #1286

Right now Not Implemented accepts no arguments, but it'd be nice if it also included a string which stated what exactly isn't implemented for cases when the range alone doesn't suffice.

Here I've just added the argument for the preexisting message, however I could also make an additional diagnostic message which has the argument so that we don't have to go fix every use of not implemented. The only issue with that is that we'd need a different diagnostic code, and based on the fact that they've been manually specified I'm assuming there's some special meaning behind the selected codes.

Without passing the argument: ERROR AS100: Not implemented: {0}
When passing the argument: ERROR AS100: Not implemented: Try Statements

So we'd likely need to go update all the current Not implemented error calls for this to go in.

Would love to have this for the closures PR so that I can make the Not implemented errors more clear

Thoughts?

@dcodeIO
Copy link
Member

dcodeIO commented May 26, 2020

So we'd likely need to go update all the current Not implemented error calls for this to go in.

I can take a look at that.

@DuncanUszkay1
Copy link
Contributor Author

Should I leave this one to you then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants