forked from Azure/azure-powershell
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New api version/asr2021 02 10 #27
Merged
nilgupta6
merged 38 commits into
newApiVersion/asr2021-02-10-v2
from
newApiVersion/asr2021-02-10
Apr 16, 2021
Merged
New api version/asr2021 02 10 #27
nilgupta6
merged 38 commits into
newApiVersion/asr2021-02-10-v2
from
newApiVersion/asr2021-02-10
Apr 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bringing Asr one sdk azure- master in sync with master branch for azure/azure-powershell
Multiple IP per nic - cmdlet changes
review changes code review changes moved validaton to nicConfig cmdlet and review changes minor fix handled review comments parameter validation changes, logs design review changes subash's multiple IP per NIC PR changes
Fixing B2A, E2A and E2E Tests and added recording
…neSdk/azure-powershell into newApiVersion/asr2021-02-10
…s for V2A and H2A
VMSS powerShell changes to common branch
TargetVmSize, AvSet, Sql RP and ResourceTagging changes for V2A and H2A
V2A test record json files
…rResource [V2A / H2A] Fixed the resource tagging parameters to clear off tags case in Set(Update) ProtectedItem cmdlet
Minor fix in playback mode for v2a unit tests
nilgupta6
added a commit
that referenced
this pull request
Apr 19, 2021
* Fixing PFO/TFO/UFO build errors * mulltiple ip per nic - cmdlet changes * review changes * code review changes * moved validaton to nicConfig cmdlet and review changes * minor fix * handled review comments * parameter validation changes, logs * design review changes * Fixing PFO/TFO/UFO build errors * mulltiple ip per nic - cmdlet changes review changes code review changes moved validaton to nicConfig cmdlet and review changes minor fix handled review comments parameter validation changes, logs design review changes subash's multiple IP per NIC PR changes * Fixing B2A, E2A and E2E Tests and added recording * [ASR][V2A/H2A] TargetVmSize, AvSet, Sql RP and ResourceTagging changes for V2A and H2A * Minor fix * vmss changes -1 * 2) vmss changes - MD files * Addressed review comments and added new tests and recordings for B2A * vmss changes * Addressed review comments * Minor fixes * Added V2A tests and recordings * PR comments * Update New-AzRecoveryServicesAsrReplicationProtectedItem.md * Minor Fix * Adding null for OdataQuery as its default value is also null. * V2A test record json files * Fix for Resource Tagging to clear off tags * Minor fix in playback mode for v2a unit tests Co-authored-by: Arpita Gupta <arpgup@microsoft.com> Co-authored-by: subashchandra31 <subash.chandra@microsoft.com> Co-authored-by: subashchandra31 <66659771+subashchandra31@users.noreply.github.com> Co-authored-by: Arpitaji <78065343+Arpitaji@users.noreply.github.com> Co-authored-by: Vidyadhari Jami <vijami@microsoft.com> Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com> Co-authored-by: prmyaka <prmyaka@microsoft.com>
imshashwataggarwal
pushed a commit
that referenced
this pull request
May 5, 2021
…2-10 (Azure#14768) * New api version/asr2021 02 10 (#27) * Fixing PFO/TFO/UFO build errors * mulltiple ip per nic - cmdlet changes * review changes * code review changes * moved validaton to nicConfig cmdlet and review changes * minor fix * handled review comments * parameter validation changes, logs * design review changes * Fixing PFO/TFO/UFO build errors * mulltiple ip per nic - cmdlet changes review changes code review changes moved validaton to nicConfig cmdlet and review changes minor fix handled review comments parameter validation changes, logs design review changes subash's multiple IP per NIC PR changes * Fixing B2A, E2A and E2E Tests and added recording * [ASR][V2A/H2A] TargetVmSize, AvSet, Sql RP and ResourceTagging changes for V2A and H2A * Minor fix * vmss changes -1 * 2) vmss changes - MD files * Addressed review comments and added new tests and recordings for B2A * vmss changes * Addressed review comments * Minor fixes * Added V2A tests and recordings * PR comments * Update New-AzRecoveryServicesAsrReplicationProtectedItem.md * Minor Fix * Adding null for OdataQuery as its default value is also null. * V2A test record json files * Fix for Resource Tagging to clear off tags * Minor fix in playback mode for v2a unit tests Co-authored-by: Arpita Gupta <arpgup@microsoft.com> Co-authored-by: subashchandra31 <subash.chandra@microsoft.com> Co-authored-by: subashchandra31 <66659771+subashchandra31@users.noreply.github.com> Co-authored-by: Arpitaji <78065343+Arpitaji@users.noreply.github.com> Co-authored-by: Vidyadhari Jami <vijami@microsoft.com> Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com> Co-authored-by: prmyaka <prmyaka@microsoft.com> * Tests tested in playback mode TestNewA2AManagedDiskReplicationConfigWithCmk A2AZoneToZoneRecoveryPlanReplication A2ATestNewContainer A2ARemoveReplicationProtectedItemDisk A2ARecoveryPlanReplication A2ANewAsrFabric vmss test Adding tests TestNewA2AManagedDiskReplicationConfig TestNewA2ADiskReplicationConfig adding ppg test for a2a * help file, PSObject and minor fixes * review comments * null check * updated test and test json * updated changeLog * skip common: v2a event test * updating SDK version * updating tests * adding comments * update online version in help files * update help file * adding breaking change exceptions * updated help file * changing breaking changes in reovery * adding recovery service changes * remove nupkg file * removing vaultcreds * adding recovery service changes * remove nupkg file * removing vaultcreds * V2A test update for linux * update V2A test Co-authored-by: Arpita Gupta <arpgup@microsoft.com> Co-authored-by: subashchandra31 <subash.chandra@microsoft.com> Co-authored-by: subashchandra31 <66659771+subashchandra31@users.noreply.github.com> Co-authored-by: Arpitaji <78065343+Arpitaji@users.noreply.github.com> Co-authored-by: Vidyadhari Jami <vijami@microsoft.com> Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com> Co-authored-by: prmyaka <prmyaka@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines