forked from Azure/azure-powershell
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple IP per nic - cmdlet changes #18
Merged
subashchandra31
merged 8 commits into
newApiVersion/asr2021-02-10
from
multipleIPPerNicCmdletChanges
Mar 24, 2021
Merged
Multiple IP per nic - cmdlet changes #18
subashchandra31
merged 8 commits into
newApiVersion/asr2021-02-10
from
multipleIPPerNicCmdletChanges
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punit-bhatt
reviewed
Mar 21, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
...eryServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicIPConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
...eryServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicIPConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
...eryServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicIPConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
...eryServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicIPConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
...eryServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicIPConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
src/RecoveryServices/RecoveryServices.SiteRecovery/Properties/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 21, 2021
src/RecoveryServices/RecoveryServices.SiteRecovery/Properties/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
requested changes
Mar 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have left comments. Please start a cmdlet design PR as well.
subashchandra31
changed the title
Multiple IP per nic - cmdlet changes (to quickly handle build issues)
Multiple IP per nic - cmdlet changes
Mar 23, 2021
punit-bhatt
reviewed
Mar 24, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...eryServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicIPConfig.cs
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
src/RecoveryServices/RecoveryServices.SiteRecovery/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
src/RecoveryServices/RecoveryServices.SiteRecovery/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Mar 24, 2021
...teRecovery/ReplicationProtectedItem/SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs
Show resolved
Hide resolved
punit-bhatt
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine. However, do verify and test these out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines