Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with iris HEAD "1.6.13" #598

Open
wants to merge 239 commits into
base: 1.18.2-dev
Choose a base branch
from

Conversation

SettingDust
Copy link

@SettingDust SettingDust commented Apr 3, 2024

fix #559

图片

IMS212 and others added 30 commits December 13, 2022 18:51
# Conflicts:
#	src/main/java/net/coderbot/iris/pipeline/newshader/NewWorldRenderingPipeline.java
#	src/main/java/net/coderbot/iris/pipeline/newshader/ShaderKey.java
#	src/main/java/net/coderbot/iris/pipeline/transform/TransformPatcher.java
deduplication of storage qualifier changing code,
import cleanup, formatting
Full Optifine core specification support
…-parsing

Improve number parsing for settings and consts
jackjt8 and others added 8 commits January 20, 2024 14:45
# Conflicts:
#	docs/guide.md
#	src/main/java/net/coderbot/iris/Iris.java
#	src/main/java/net/coderbot/iris/compat/sodium/mixin/shader_overrides/MixinGlRenderDevice.java
#	src/main/java/net/coderbot/iris/gl/program/ComputeProgram.java
#	src/main/java/net/coderbot/iris/mixin/MixinGlStateManager_FramebufferBinding.java
#	src/main/java/net/coderbot/iris/mixin/MixinLevelRenderer.java
#	src/main/java/net/coderbot/iris/mixin/MixinShaderInstance.java
#	src/main/java/net/coderbot/iris/pipeline/newshader/ExtendedShader.java
#	src/main/java/net/coderbot/iris/pipeline/newshader/ShaderInstanceInterface.java
#	src/main/java/net/coderbot/iris/pipeline/transform/parameter/AttributeParameters.java
#	src/main/java/net/coderbot/iris/pipeline/transform/parameter/GeometryInfoParameters.java
#	src/main/java/net/coderbot/iris/postprocess/CompositeRenderer.java
#	src/main/java/net/coderbot/iris/postprocess/FinalPassRenderer.java
#	src/main/resources/fabric.mod.json
#	src/sodiumCompatibility/resources/mixins.iris.compat.sodium.json
@SettingDust SettingDust changed the title Merge with Iris 1.6.11+1.18.2 merge with iris HEAD "1.6.13" Apr 3, 2024
@SettingDust SettingDust marked this pull request as draft April 3, 2024 05:31
@SettingDust
Copy link
Author

Tested in dawncraft

2024-04-03_14 44 54

2024-04-03_14 43 55

@SettingDust SettingDust marked this pull request as ready for review April 3, 2024 06:47
@SettingDust
Copy link
Author

Need more test.

oculus-1.6.13-dust.jar.zip

@esotericist
Copy link

esotericist commented Apr 3, 2024

edit: just looked closer again at the opening post, and that definitely shows BSL not working correctly. are you sure this is ready for review?

mc 1.18.2, forge 40.2.17, dh 2.0.2-a-dev (downloaded this morning), embeddium 0.3.12, and the above oculus build.

this is all with an i7 laptop using iris-xe onboard graphics. i know from one of the dh folks that this machine SHOULD be able to pull this off, if i was using iris on fabric.

dh is definitely working (was doing testing with it this morning before downloading the oculus build, plus you can see it loading the chunks)

summary: bsl almost works, while complementary unbound is a little behind. bliss, photon, and shrimple definitely do not work. didn't include a photon screenshot, it looks very close to the same as bliss. only bothered including shrimple because it had a novel fail state.

with bsl 8.2.09p1.
2024-04-03_06 40 03
2024-04-03_06 40 07
2024-04-03_06 40 16

with complementary unbound r5.1.1 (if there's a better version i'm not sure where it is, it isn't in the list of compatible things in the iris discord)
(since i took this shot i have found the fog setting and turned that off, but the dh chunks are still not rendered right)
2024-04-03_07 00 39

with bliss (from https://github.com/X0nk/Bliss-Shader/archive/refs/heads/main.zip )
2024-04-03_06 42 57

with shrimple (from https://github.com/Null-MC/Shrimple/archive/refs/heads/main.zip ) for funsies:
2024-04-03_06 49 21

@dima-dencep dima-dencep requested a review from Asek3 April 3, 2024 14:36
@SettingDust
Copy link
Author

SettingDust commented Apr 3, 2024

@esotericist you need to compare with iris 1.18 on fabric.

Bliss on Iris 1.18.2 fabric
X0nk/Bliss-Shader#80
2024-04-03_23 15 42

@SettingDust
Copy link
Author

This update is Iris 1.6.13 instead of 1.7.0 that is beta. So the support for DH is "legacy" instead of "v2"
https://gist.github.com/Steveplays28/52db568f297ded527da56dbe6deeec0e

@esotericist
Copy link

This update is Iris 1.6.13 instead of 1.7.0 that is beta. So the support for DH is "legacy" instead of "v2" https://gist.github.com/Steveplays28/52db568f297ded527da56dbe6deeec0e

ah, that wasn't clear from the pr. alright

@dima-dencep
Copy link
Collaborator

Does iris use mixinextras?
I don't think so, which is why you need to give up on them here as well

@SettingDust
Copy link
Author

Does iris use mixinextras? I don't think so, which is why you need to give up on them here as well

https://github.com/Asek3/Oculus/tree/1.18.2-dev/src/main/java/llamalad7/mixinextras
oculus using it

@dima-dencep
Copy link
Collaborator

oculus using it

only in 1.18.2, and that doesn't mean you can use mixinextras in this pr.

@SettingDust
Copy link
Author

only in 1.18.2, and that doesn't mean you can use mixinextras in this pr.

Why not?

@dima-dencep
Copy link
Collaborator

Why not?

Because this pr should just update oculus to iris 1.16.13 and nothing more, other stuff needs a separate PR

@SettingDust
Copy link
Author

Because this pr should just update oculus to iris 1.16.13 and nothing more, other stuff needs a separate PR

Make sense. You can close this or edit it since Allow edits and access to secrets by maintainers checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.