Skip to content

Conversation

@pherrymason
Copy link
Contributor

Complementary fix to #3.
Previous

 for( var i in parents ) 
    parents[i] = parents[i].slice(parents[i].length - minlen);
 }

Does not iterate through elements but array methods aswell.

Arwid added a commit that referenced this pull request Mar 10, 2013
* Fixes problem with IE8 throwing exception in commonAncestor.
@Arwid Arwid merged commit 05ae7b6 into Arwid:master Mar 10, 2013
@Arwid
Copy link
Owner

Arwid commented Mar 10, 2013

Thanks Raúl. If you'd like, comment on http://stackoverflow.com/questions/3217147/jquery-first-parent-containing-all-children#answer-3217279 so that it's fixed there as well.

Arwid added a commit that referenced this pull request Mar 10, 2013
@pherrymason
Copy link
Contributor Author

Done! Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants