Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in kafka producer that panicked on key serialization #574

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix regression in kafka producer that panicked on key serialization #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions crates/arroyo-connectors/src/kafka/sink/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,18 +171,9 @@ impl ArrowOperator for KafkaSinkFunc {
async fn process_batch(&mut self, batch: RecordBatch, ctx: &mut ArrowContext) {
let values = self.serializer.serialize(&batch);

if let Some(key_indices) = &ctx.in_schemas[0].key_indices {
let k = batch.project(key_indices).unwrap();

// TODO: we can probably batch this for better performance
for (k, v) in self.serializer.serialize(&k).zip(values) {
self.publish(Some(k), v, ctx).await;
}
} else {
for v in values {
self.publish(None, v, ctx).await;
}
};
for v in values {
self.publish(None, v, ctx).await;
}
}

async fn handle_checkpoint(&mut self, _: CheckpointBarrier, ctx: &mut ArrowContext) {
Expand Down
2 changes: 0 additions & 2 deletions crates/arroyo-operator/src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,6 @@ impl ArrowContext {
if self.buffer.as_ref().unwrap().size() > 0 {
let buffer = self.buffer.take().unwrap();
let batch = buffer.finish();
println!("{}\t{}", batch.num_rows(), batch.get_array_memory_size());
self.collector.collect(batch).await;
self.buffer = Some(ContextBuffer::new(
self.out_schema.as_ref().map(|t| t.schema.clone()).unwrap(),
Expand All @@ -570,7 +569,6 @@ impl ArrowContext {
if let Some(buffer) = deserializer.flush_buffer() {
match buffer {
Ok(batch) => {
println!("{}\t{}", batch.num_rows(), batch.get_array_memory_size());
self.collector.collect(batch).await;
}
Err(e) => {
Expand Down
Loading