Fix regression in kafka producer that panicked on key serialization #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in kafka serialization that causes run-time panics. The deserializer can only deserialize value schemas (as it has logic to project out the non-timestamp columns). In the Kafka producer, we had logic to also serialize the keys if they were present. That was previously ignored, because there never ends up being a key in the graph produced by SQL. However, when we changed the key representation to be an
Option<Vec<usize>>, that is now Some but with an empty schema, causing the key serialization code to run but panic due to not having any columns.