Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-magistrate): use correct size for BridgechainUpdate asset buffer #3284

Closed
wants to merge 1 commit into from

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Nov 19, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated
Copy link
Contributor

dated commented Nov 19, 2019

Fwiw I had fixed that in #3255 already

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #3284 into develop will increase coverage by 35.61%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #3284       +/-   ##
===========================================
+ Coverage    29.78%   65.4%   +35.61%     
===========================================
  Files          431     431               
  Lines        12129   12129               
  Branches      1635    1635               
===========================================
+ Hits          3613    7933     +4320     
+ Misses        8490    4163     -4327     
- Partials        26      33        +7
Impacted Files Coverage Δ
...rate-crypto/src/transactions/bridgechain-update.ts 27.77% <0%> (+27.77%) ⬆️
...crypto/src/transactions/bridgechain-resignation.ts 55.55% <0%> (+55.55%) ⬆️
...ages/core-api/src/handlers/transactions/methods.ts 100% <0%> (ø) ⬆️
...s/core-api/src/handlers/shared/schemas/block-id.ts 100% <0%> (ø) ⬆️
packages/core-tester-cli/src/logger.ts 100% <0%> (ø) ⬆️
.../core-api/src/handlers/transactions/transformer.ts 100% <0%> (ø) ⬆️
packages/core-api/src/handlers/peers/schema.ts 100% <0%> (ø) ⬆️
...ackages/core-api/src/handlers/locks/transformer.ts 100% <0%> (ø) ⬆️
...kages/core-api/src/handlers/transactions/routes.ts 100% <0%> (ø) ⬆️
...kages/core-tester-cli/src/commands/debug/verify.ts 100% <0%> (ø) ⬆️
... and 315 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f67f7...dd2f450. Read the comment docs.

@spkjp spkjp closed this Nov 19, 2019
@spkjp spkjp deleted the fix/core-magistrate/buffer branch November 19, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants