feat(core-magistrate-crypto): add ports to bridgechain registration/update

[dated]

Summary

Adds a ports property to the bridgechain transaction types. This property holds an object with plugin names as keys, and port numbers as values like the ports property on peers. For the time being the only allowed plugin to be included is @arkecosystem/core-api.

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[lgtm-com]

This pull request introduces 1 alert when merging d22db35 into 0663b0f - view on LGTM.com

new alerts:

• 1 for Assignment to constant

[spkjp]

We need a devnet-only milestone to not need to rollback again. Can you add one like we already did for invalid timestamps?

In other words we need to skip the new serde when on devnet and some milestone constant (e.g. skipBridgechainPortSerialization) is set. Like here:
https://github.com/ArkEcosystem/core/blob/develop/packages/crypto/src/blocks/block.ts#L230

And to get around the new schema we can simply use the exceptions.json where most bridgechain transactions already got added.

[dated]

Sure, I'll have a look as soon as possible.

[dated]

#3258 might require a rollback - is that up for discussion at the moment after all?

[ghost]

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

[ghost]

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

Changed

[ghost]

Your pull request has been merged and marked as tier 2. It will earn you $100 USD.