Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): return all types from the /transactions/types endpoint #2878

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 15, 2019

{
    "data": {
        "Core": {
            "Transfer": 0,
            "SecondSignature": 1,
            "DelegateRegistration": 2,
            "Vote": 3,
            "MultiSignature": 4,
            "Ipfs": 5,
            "MultiPayment": 6,
            "DelegateResignation": 7,
            "HtlcLock": 8,
            "HtlcClaim": 9,
            "HtlcRefund": 10
        }
    }
}

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@spkjp spkjp merged commit ee80ac5 into develop Aug 15, 2019
@ghost ghost deleted the refactor/core-api/transaction-types branch August 15, 2019 18:20
vasild added a commit that referenced this pull request Aug 16, 2019
…-nonce-in-block-validation

* ArkEcosystem/core/develop:
  refactor: return all registered transaction types (#2878)
  refactor(crypto): signature deserialization (#2877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants