Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): signature deserialization #2877

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 15, 2019

Ensures that a V2 transaction that uses ECDSA can still be properly deserialized.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@7da2373). Click here to learn what that means.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2877   +/-   ##
==========================================
  Coverage           ?   67.27%           
==========================================
  Files              ?      379           
  Lines              ?     9051           
  Branches           ?      441           
==========================================
  Hits               ?     6089           
  Misses             ?     2929           
  Partials           ?       33
Impacted Files Coverage Δ
packages/crypto/src/transactions/verifier.ts 90.9% <ø> (ø)
...ges/crypto/src/transactions/types/multi-payment.ts 100% <100%> (ø)
...s/crypto/src/transactions/types/multi-signature.ts 66% <100%> (ø)
...kages/crypto/src/transactions/types/htlc-refund.ts 100% <100%> (ø)
...ckages/crypto/src/transactions/types/htlc-claim.ts 100% <100%> (ø)
packages/crypto/src/transactions/signer.ts 90.9% <100%> (ø)
...pto/src/transactions/types/delegate-resignation.ts 100% <100%> (ø)
...ackages/crypto/src/transactions/types/htlc-lock.ts 100% <100%> (ø)
packages/crypto/src/transactions/types/ipfs.ts 100% <100%> (ø)
packages/crypto/src/transactions/deserializer.ts 90.8% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2373...36458c0. Read the comment docs.

@faustbrian faustbrian merged commit b083dbe into develop Aug 15, 2019
@faustbrian faustbrian deleted the refactor/crypto/signature-deserialization branch August 15, 2019 13:29
vasild added a commit that referenced this pull request Aug 16, 2019
…-nonce-in-block-validation

* ArkEcosystem/core/develop:
  refactor: return all registered transaction types (#2878)
  refactor(crypto): signature deserialization (#2877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants