Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-transaction-pool): Switch expiration to chain height #2461

Merged
merged 25 commits into from
Apr 26, 2019

Commits on Apr 23, 2019

  1. feat(core-transaction-pool): Switch expiration to chain height

    Switch from calculating transactions' expiration in "number of seconds
    since genesis block" to "chain height".
    
    Notice: this change alters the semantic of the maxTransactionAge beyond
    just the units (seconds vs height). Before the change we would use the
    user-defined transaction.timestamp and add maxTransactionAge (seconds)
    to it. After the change we use the current chain height when we have
    received the transaction (which is not user-defined and not necessary
    the same as when the transaction was created by the user) and add
    maxTransactionAge (height) to it.
    
    Resolves #1060
    vasild committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    525f165 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e61fa9f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Configuration menu
    Copy the full SHA
    2b76687 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6df72c View commit details
    Browse the repository at this point in the history
  3. Update __tests__/unit/core-transaction-pool/connection.test.ts

    Co-Authored-By: vasild <vd@freebsd.org>
    faustbrian and vasild authored Apr 24, 2019
    Configuration menu
    Copy the full SHA
    8186c8a View commit details
    Browse the repository at this point in the history
  4. Update __tests__/unit/core-transaction-pool/connection.test.ts

    Co-Authored-By: vasild <vd@freebsd.org>
    faustbrian and vasild authored Apr 24, 2019
    Configuration menu
    Copy the full SHA
    da79b1c View commit details
    Browse the repository at this point in the history
  5. Update __tests__/unit/core-transaction-pool/connection.test.ts

    Co-Authored-By: vasild <vd@freebsd.org>
    faustbrian and vasild authored Apr 24, 2019
    Configuration menu
    Copy the full SHA
    4675364 View commit details
    Browse the repository at this point in the history
  6. Update packages/core-transaction-pool/src/memory.ts

    Co-Authored-By: vasild <vd@freebsd.org>
    faustbrian and vasild authored Apr 24, 2019
    Configuration menu
    Copy the full SHA
    086aa30 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6c10fe5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9794070 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4d1e25c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1e58fe3 View commit details
    Browse the repository at this point in the history
  11. fix(core-transaction-pool): get current height in a more robust way

    and handle the case if we are unable to get it
    vasild committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    0167421 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fb8631b View commit details
    Browse the repository at this point in the history
  13. test(core-transaction-pool): disable tx exiration test

    The test needs to query the current chain height and then wait until it
    increases or fake an increased height.
    vasild committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    31c0835 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Merge remote-tracking branch 'ArkEcosystem/core/develop' into transac…

    …tion-expiration-in-height
    
    * ArkEcosystem/core/develop:
      release: 2.3.15 (#2478)
      release: 2.3.14 (#2477)
      refactor(core): remove support for old release channels (#2476)
      fix(crypto): add exceptions for transactions with invalid recipients (#2471)
      refactor(crypto): make all Slots.* methods static (#2473)
      docs(template): add release section to pull request template (#2472)
      chore: fix absolute banner urls (#2469)
    vasild committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    dd58504 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd1c4ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de89d7a View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'ArkEcosystem/core/develop' into transac…

    …tion-expiration-in-height
    
    * ArkEcosystem/core/develop:
      style: apply linting and formatting to e2e tests (#2480)
    vasild committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    68334f7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    00b0a22 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'ArkEcosystem/core/develop' into transac…

    …tion-expiration-in-height
    
    * ArkEcosystem/core/develop:
      feat: add core-state to manage the state of in-memory data (#2479)
    vasild committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    21845ee View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e5581c8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a2b52a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Merge remote-tracking branch 'ArkEcosystem/core/develop' into transac…

    …tion-expiration-in-height
    
    * ArkEcosystem/core/develop:
      fix(core): parse only the last line of pm2 stdout (#2484)
      release: 2.3.18 (#2488)
      fix(core-snapshots): reset unfinished round after import (#2486)
      fix(core-forger): update configManager height (#2487)
      release: 2.3.16 (#2483)
      fix(core-database): initialize height on startup (#2482)
    vasild committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    541c2e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    156cd28 View commit details
    Browse the repository at this point in the history