Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: apply linting and formatting to e2e tests #2480

Merged
merged 2 commits into from
Apr 25, 2019
Merged

style: apply linting and formatting to e2e tests #2480

merged 2 commits into from
Apr 25, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Apr 25, 2019 •
edited
Loading

Summary

Apply tslint and prettier rules to e2e files.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Apr 25, 2019

The ci/circleci: test-node11-unit job is failing as of 2ed2d87279ec5318e26a3fba86baaa14535d7d9e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 24cedff into develop Apr 25, 2019
@ghost ghost deleted the style/e2e branch April 25, 2019 10:10
@codecov-io
Copy link

codecov-io commented Apr 25, 2019 •
edited
Loading

Codecov Report

Merging #2480 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2480   +/-   ##
========================================
  Coverage    67.82%   67.82%           
========================================
  Files          386      386           
  Lines         8396     8396           
  Branches       398      438   +40     
========================================
  Hits          5695     5695           
+ Misses        2649     2648    -1     
- Partials        52       53    +1
Impacted Files Coverage Δ
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3289f...2ed2d87. Read the comment docs.

vasild added a commit that referenced this pull request Apr 25, 2019
@vasild
Merge remote-tracking branch 'ArkEcosystem/core/develop' into transac…
68334f7 
…tion-expiration-in-height

* ArkEcosystem/core/develop:
  style: apply linting and formatting to e2e tests (#2480)
@ghost ghost mentioned this pull request Apr 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@air1one air1one Awaiting requested review from air1one

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faustbrian @codecov-io