fix(core-api): fix /api/lock/unlocked payload validation (#4488)

* Fix /locks/unlocked schema * Fix locks unit test
ArkEcosystem · Sep 14, 2021 · 72562a6 · 72562a6
1 parent e51071a
commit 72562a6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/__tests__/integration/core-api/controllers/locks.test.ts b/__tests__/integration/core-api/controllers/locks.test.ts
@@ -88,3 +88,14 @@ describe("/locks", () => {
         }
     });
 });
+
+describe("/locks/unlocked", () => {
+    it("should return 422 response status when payload is empty object", async () => {
+        const client = app.resolve(ApiInjectClient);
+        const response = await client.post("/locks/unlocked", {});
+
+        expect(response).toMatchObject({
+            status: 422,
+        });
+    });
+});
diff --git a/__tests__/unit/core-api/routes/locks.test.ts b/__tests__/unit/core-api/routes/locks.test.ts
@@ -66,7 +66,7 @@ describe("Locks", () => {
             const injectOptions = {
                 method: "POST",
                 url: "/locks/unlocked",
-                payload: {},
+                payload: { ids: ["bc3ee5fe72cb4c73521aef576d6d53ba3323dd9cb652f33bf613d22e7f7185a8"] },
             };
 
             const result = await server.inject(injectOptions);

diff --git a/packages/core-api/src/routes/locks.ts b/packages/core-api/src/routes/locks.ts
@@ -46,8 +46,8 @@ export const register = (server: Hapi.Server): void => {
                     orderBy: server.app.schemas.orderBy,
                 }).concat(Schemas.pagination),
                 payload: Joi.object({
-                    ids: Joi.array().unique().min(1).max(25).items(Joi.string().hex().length(64)),
-                }),
+                    ids: Joi.array().unique().min(1).max(25).items(Joi.string().hex().length(64)).required(),
+                }).required(),
             },
             plugins: {
                 pagination: {