-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sessions feature #5158
Open
RogerHYang
wants to merge
11
commits into
main
Choose a base branch
from
sessions2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: sessions feature #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Oct 22, 2024
RogerHYang
added
feature branch
a feature branch that consolidates multiple features into a single commit on main
DO NOT MERGE
labels
Oct 22, 2024
Parker-Stafford
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking feature branch
RogerHYang
force-pushed
the
sessions2
branch
4 times, most recently
from
October 25, 2024 17:13
aee3252
to
0bbd3f5
Compare
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Oct 28, 2024
RogerHYang
force-pushed
the
sessions2
branch
3 times, most recently
from
October 31, 2024 18:19
bf6c625
to
4537967
Compare
RogerHYang
force-pushed
the
sessions2
branch
2 times, most recently
from
November 7, 2024 23:12
f86ab63
to
d36a5f1
Compare
RogerHYang
force-pushed
the
sessions2
branch
from
November 13, 2024 18:43
d36a5f1
to
38eaee4
Compare
* feat(sesions): add session details page * remove unused import, add error boundary * pull user from root span
* feat(sessions): add trace latency p50 to session details * fix type for latency in ui * update test, fix where clause * add is not none check for db filter * revert latency dataloader changes * revert dataloader changes for project span and trace latency * refactor to use its own data loader * remove extra param from test * add unit tests * ruff * fix import * fix name filter in other dataloader tests * update unit test fixture naming, add unit test for project session graphql trace_latency_ms_quantile field * clean up imports * pin aiohttp * fix unit test deps
…ut output values (#5257)
RogerHYang
force-pushed
the
sessions2
branch
from
November 13, 2024 19:16
38eaee4
to
2706d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
feature branch
a feature branch that consolidates multiple features into a single commit on main
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.