refactor(sessions): add dataloaders for session queries #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
dosubot
bot
added
size:XL
axiomofjoy
approved these changes
Oct 29, 2024
src/phoenix/server/api/dataloaders/session_first_input_last_outputs.py
Outdated
Show resolved
Hide resolved
src/phoenix/server/api/context.py
Outdated
| @@ -68,6 +71,10 @@ class DataLoaders: | |||
| latency_ms_quantile: LatencyMsQuantileDataLoader | |||
| min_start_or_max_end_times: MinStartOrMaxEndTimeDataLoader | |||
| record_counts: RecordCountDataLoader | |||
| session_first_inputs: SessionFirstInputLastOutputsDataLoader | |||
There was a problem hiding this comment.
Suggested change
| session_first_inputs: SessionFirstInputLastOutputsDataLoader | |
| session_inputs: SessionIODataLoader |
There was a problem hiding this comment.
I think this can be ambiguous, since it can imply a list of inputs per session, whereas first_input matches the graphql field, which is more explicit
Comment on lines
27
to
32
| stmt = ( | ||
| select(models.Trace.project_session_rowid.label("id_")) | ||
| .join_from(models.Span, models.Trace) | ||
| .where(models.Span.parent_id.is_(None)) | ||
| .where(models.Trace.project_session_rowid.isnot(None)) | ||
| ) |
There was a problem hiding this comment.
Do we need to handle the case of multiple root spans in a single trace?
There was a problem hiding this comment.
we're punting on that for now, since there' no good way to display them
There was a problem hiding this comment.
How does the query plan look with the row number/ filter on rank approach?
There was a problem hiding this comment.
here's the query plan from postgres
axiomofjoy
reviewed
Oct 29, 2024
Comment on lines
35
to
36
| models.Span.attributes[INPUT_VALUE].label("value"), | ||
| models.Span.attributes[INPUT_MIME_TYPE].label("mime_type"), |
There was a problem hiding this comment.
Same non-blocking comment as before.
dosubot
bot
added
size:L
RogerHYang
added a commit
that referenced
this pull request
Oct 29, 2024
RogerHYang
added a commit
that referenced
this pull request
Oct 31, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 5, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 7, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 13, 2024
RogerHYang
added a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.