forked from ETS-Next-Gen/writing_observer
-
Notifications
You must be signed in to change notification settings - Fork 2
Updating the plugin to deal with event elements. #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DrLynch
wants to merge
596
commits into
master
Choose a base branch
from
TypeCheck
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change PR.
- Moved writing highlight dashboard to its own module - Removed any excess code from prototype stage - Renamed to wo_highlight_dashboard - Need to `pip uninstall wo_dash` (old prototype package) - Then cd into the wo_highlight_dashboard and `pip install -e .`
Moved dash dashboard out of prototypes
- Fixed sorting - now includes the sorting items as items to pass to the NLP - indicators are still the only supported items - probably a small change to the js code could fix this - Categorized the NLP items a little more - added general and source-based category to code - should get refactored in the future - currently just displays general items - need to create code that combines general with others - a deep merge between general and argumentative/narrative/source-based is fine - Just have generic transition words right now, not everything
- cleaned up styling - Added writing_observer to module (code I did not add earlier, but this is the right type of change to include.
Merging in creds.yaml tweak.
Content script reload
JohnDamilola
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
DrLynch
pushed a commit
that referenced
this pull request
Oct 20, 2023
Full commit list: * moved files to new extension build process directory * adjusted imports and undefined var error * updated documentation with extension readme and updated readme * added names and git repo * added version, probably needs a bump or a central location for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of basic type wrapper.