-
Notifications
You must be signed in to change notification settings - Fork 2
Add menu dropdown and status button #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| html.Div( | ||
| [ | ||
| settings.open_btn | ||
| dbc.Button( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add these are items in the dropdown menu. That way the menu contains more than just logout. You may have to alter the settings.open_btn to address this. The settings open button also includes a cog (settings icon), that can probably be removed if its moved into the dropdown. There is a classname on the text of the open settings button that hides when the screen is small, this will need to be addressed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradley-erickson I'll be pushing it in a bit, but first, I want to advice that we shouldn't put the "last updated" status in the dropdown too for consistency sake since it is not a actionable/clickable button.
I have added the settings toggle button into the dropdown, if you give me a go ahead, I will just update my PR with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wrap the button and the dropdown menu in a button group and include a picture with it as well?
See the dropdown section here.
Using outlines instead of full color buttons might look a little nicer as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have wrapped it in the button group, but what do you mean by "include a picture with it as well"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just take a screenshot. and include it here. That way we and whoever else looks at this PR can quickly see what's changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


No description provided.