Skip to content

Conversation

@JohnDamilola
Copy link
Collaborator

No description provided.

html.Div(
[
settings.open_btn
dbc.Button(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add these are items in the dropdown menu. That way the menu contains more than just logout. You may have to alter the settings.open_btn to address this. The settings open button also includes a cog (settings icon), that can probably be removed if its moved into the dropdown. There is a classname on the text of the open settings button that hides when the screen is small, this will need to be addressed as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradley-erickson I'll be pushing it in a bit, but first, I want to advice that we shouldn't put the "last updated" status in the dropdown too for consistency sake since it is not a actionable/clickable button.

I have added the settings toggle button into the dropdown, if you give me a go ahead, I will just update my PR with that

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap the button and the dropdown menu in a button group and include a picture with it as well?

See the dropdown section here.

Using outlines instead of full color buttons might look a little nicer as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have wrapped it in the button group, but what do you mean by "include a picture with it as well"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just take a screenshot. and include it here. That way we and whoever else looks at this PR can quickly see what's changed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI Changes

Screenshot 2022-12-23 at 13 34 33
Screenshot 2022-12-23 at 13 34 44

@DrLynch DrLynch merged commit 78c3f61 into master Dec 26, 2022
DrLynch pushed a commit that referenced this pull request Mar 3, 2023
Merging in creds.yaml tweak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants