CustomWarning: fix repeattime logic

The RepeatTime setting was also the worst-case detection time
ArduPilot · Nov 12, 2024 · b5a456f · b5a456f
1 parent b8a5cc9
commit b5a456f
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/ExtLibs/Utilities/Warnings/CustomWarning.cs b/ExtLibs/Utilities/Warnings/CustomWarning.cs
@@ -183,40 +183,45 @@ public bool CheckValue(bool userepeattime = true)
             if (userepeattime && DateTime.Now < lastrepeat.AddSeconds(RepeatTime))
                 return false;
 
-            lastrepeat = DateTime.Now;
+            bool condition = false;
 
             switch (ConditionType)
             {
                 case Conditional.EQ:
                     if (GetValue == Warning)
-                        return true;
+                        condition = true;
                     break;
                 case Conditional.GT:
                     if (GetValue > Warning)
-                        return true;
+                        condition = true;
                     break;
                 case Conditional.GTEQ:
                     if (GetValue >= Warning)
-                        return true;
+                        condition = true;
                     break;
                 case Conditional.LT:
                     if (GetValue < Warning)
-                        return true;
+                        condition = true;
                     break;
                 case Conditional.LTEQ:
                     if (GetValue <= Warning)
-                        return true;
+                        condition = true;
                     break;
                 case Conditional.NEQ:
                     if (GetValue != Warning)
-                        return true;
+                        condition = true;
                     break;
                 case Conditional.NONE:
 
                     break;
             }
 
-            return false;
+            if (condition)
+            {
+                lastrepeat = DateTime.Now;
+            }
+
+            return condition;
         }