SLSA fix #468
Open
SLSA fix #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Windows build workflow by enhancing build provenance generation, debugging, and SLSA verification reliability.
- Added new permissions and debug steps for GitHub token and repository context
- Upgraded the SLSA verifier version and introduced fallback logic for provenance generation and verification
| $fileHash = (Get-FileHash -Algorithm SHA256 $_.FullName).Hash.ToLower() | ||
| Write-Host "File hash: $fileHash" | ||
|
|
||
| if (-not $useBasicVerification) { |
There was a problem hiding this comment.
Consider initializing $useBasicVerification to false before its usage (e.g., before the try block) to improve code clarity and avoid potential ambiguity in the verification logic.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
.github/workflows/windows_build.ymlfile to enhance build provenance generation, improve debugging, and update dependencies. It introduces new steps for handling SLSA provenance files, adds debugging for GitHub token and permissions, and upgrades the SLSA verifier version. Additionally, it includes fallback mechanisms for provenance generation and verification to improve reliability.Enhancements to Build Provenance and Verification:
actions/attest-build-provenance@v2.3.0action, ensuring provenance is created for the build artifacts ([.github/workflows/windows_build.ymlR107-R116](https://github.com/ArduPilot/MethodicConfigurator/pull/468/files#diff-4f99d7a5ccc527af64c0d4fca4d4065b5400c04c60f188181d532fcbc0a5af8eR107-R116)).[.github/workflows/windows_build.ymlL106-R441](https://github.com/ArduPilot/MethodicConfigurator/pull/468/files#diff-4f99d7a5ccc527af64c0d4fca4d4065b5400c04c60f188181d532fcbc0a5af8eL106-R441)).[.github/workflows/windows_build.ymlL106-R441](https://github.com/ArduPilot/MethodicConfigurator/pull/468/files#diff-4f99d7a5ccc527af64c0d4fca4d4065b5400c04c60f188181d532fcbc0a5af8eL106-R441)).Debugging and Permissions:
[.github/workflows/windows_build.ymlR84-R98](https://github.com/ArduPilot/MethodicConfigurator/pull/468/files#diff-4f99d7a5ccc527af64c0d4fca4d4065b5400c04c60f188181d532fcbc0a5af8eR84-R98)).Dependency Updates:
v2.5.1tov2.7.0and added verification for successful downloads ([.github/workflows/windows_build.ymlL106-R441](https://github.com/ArduPilot/MethodicConfigurator/pull/468/files#diff-4f99d7a5ccc527af64c0d4fca4d4065b5400c04c60f188181d532fcbc0a5af8eL106-R441)).Reliability Improvements:
echocommands withOut-Fileto ensure consistent file encoding and appending behavior ([.github/workflows/windows_build.ymlL106-R441](https://github.com/ArduPilot/MethodicConfigurator/pull/468/files#diff-4f99d7a5ccc527af64c0d4fca4d4065b5400c04c60f188181d532fcbc0a5af8eL106-R441)).These changes collectively improve the security, reliability, and maintainability of the Windows build workflow.