Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests, WebHost: add tests for host_room and minor cleanup #3619

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

  • Tests behaviour that was added in WebHost: Better host room #3496 and would've found the mistake that was fixed in WebHost: Log: handle FileNotFoundError #3603
  • Tests that only the owner can see the log and queue commands
  • Moves flask app init for tests to a common place (and ignores failure from double init)
  • Create 1 flask client per test rather than per class
  • Enables DEBUG for those, which allows printing the server traceback on failure
  • Fix some typing and a typo in test_api_generate

How was this tested?

pytest, pytest-xdist

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 4, 2024
This is what custom_server does now.
@black-sliver black-sliver merged commit c96c554 into ArchipelagoMW:main Jul 7, 2024
17 checks passed
@black-sliver black-sliver deleted the test-host_room branch July 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants