Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: Log: handle FileNotFoundError #3603

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

yielding from a generator function would raise the error outside of the try block. This opens the file before entering the generator.

How was this tested?

Local webhost with waitress, starting a room and deleting the file. Seeing no errors being logged to console.

@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 1, 2024
Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@black-sliver black-sliver merged commit b6925c5 into ArchipelagoMW:main Jul 1, 2024
17 checks passed
@black-sliver black-sliver deleted the webhost-log-fix branch July 1, 2024 23:04
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants