CommonClient: Use lookup_in_game instead of lookup_in_slot in case of own-game name lookup when disconnected from server.
#3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` in case of own-game name lookup when disconnected from server.
ThePhar
added
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
Berserker66
approved these changes
Jun 14, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…f own-game name lookup when disconnected from server. (ArchipelagoMW#3514)
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…f own-game name lookup when disconnected from server. (ArchipelagoMW#3514)
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…f own-game name lookup when disconnected from server. (ArchipelagoMW#3514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Bug Report: https://discord.com/channels/731205301247803413/1249434122212872252
There are some code paths that attempt to lookup names prior to connection to the Archipelago server, and I foolishly used
lookup_in_sloteverywhere when I refactored for #1933. This caused some areas to raise an exception and not finish prior to queuing LocationChecks packets, causing a failure to sync local state with server (like in Factorio's case in the bug report).This changes those methods to
lookup_in_gameas CommonContext-derived clients should have already set the game value, so this lookup for own-game items should work even while disconnected.How was this tested?
Ran before and after with a Factorio world that had a location checked prior to connection. The location did not resync before, but did successfully after the changes. Other clients are not tested, but assumed to work correctly based on similar usage.
If this makes graphical changes, please attach screenshots.
N/A