-
Notifications
You must be signed in to change notification settings - Fork 1
release-master-2024-07-04-tagging-tool-improvements #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in tags 🔨 refactor(translation.json): add missing translations for "Show more" in tags in Italian translation
This commit updates the dependency on @appquality/unguess-design-system from version 3.1.101 to version 3.1.102 in the package.json file. This update includes bug fixes and improvements to the design system. It is important to keep our dependencies up to date to ensure compatibility and take advantage of the latest features and fixes.
This commit updates the video player URL handling in the `Player.tsx` component. Instead of directly using `video.url`, the code now checks if `video.streamUrl` is available and uses it as the URL if present, falling back to `video.url` otherwise. This change improves the flexibility of the video player and allows for better integration with different video sources. Additionally, a play button has been added to the transcript in the `ParagraphMeta.tsx` component. Clicking the play button will set the current time of the video to the start time of the corresponding paragraph. Note: This suggested commit message follows the established convention of using a prefix (feat) to indicate a new feature or enhancement.
🔨 refactor(translation.json): add missing translation for "Show more" in tags
…script Improve player and transcript usability
…idation 🔧 fix(Observation.tsx): update title variable to use tags instead of title 🔧 fix(ObservationForm.tsx): adjust form validation for title field 🚀 feat(TitleDropdown.tsx): add TitleDropdown component for selecting titles
New Crowdin updates
…d video tags The code changes in TitleDropdown.tsx enhance the functionality of the TitleDropdown component. The onSelect function now handles the selection of a title and adds video tags based on the selected item. Additionally, the setSelectedItem function is called to update the selected item, and the setInputValue function is called to clear the input value. These changes improve the user experience when selecting titles and adding video tags. Note: This suggested commit message follows the established convention of using a prefix (feat) to indicate a new feature or enhancement.
🚀 feat(ObservationForm.tsx): handle title as a tag
…ted quotes The code changes in Observation.tsx and ObservationForm.tsx modify the components to use the generated quotes instead of the deprecated "quots" prop. This update improves the consistency and clarity of the codebase. Note: This suggested commit message follows the established convention of using a prefix (feat) to indicate a new feature or enhancement.
…nerated quotes condictionally transcript exists
New Crowdin updates
The z-index value in Player.tsx has been updated from 3 to 101. This change improves the stacking order of the Player component, ensuring it appears above other elements on the page. Note: This suggested commit message follows the established convention of using a prefix (feat) to indicate a new feature or enhancement.
…-overlap Update z-index value of PlayerContainer
Utt 34 quotes
…opdown 🔧 refactor(TitleDropdown.tsx): improve display of selected item and matching options
…ssage format 🔀 chore(translation.json): add missing translation for multiple image and video labels 🔀 chore(translation.json): add missing translations for multiple show more labels 🔀 chore(translation.json): update translation for multiple count labels in Italian 🔀 chore(translation.json): update translation for multiple count labels in Italian 🔧 fix(Actions.tsx): change CopyIcon to ShareIcon for observation copying 🔧 fix(Observation.tsx): add Divider component for better UI separation 🔧 fix(ParagraphMeta.tsx): replace StyledButton with IconButton for play icon 🔨 refactor(Metas.tsx): update import for Span component 🔧 chore(Metas.tsx): add appTheme import for color palette usage 🚀 feat(Metas.tsx): calculate observations count for videos with severity tags 🔒 fix(Metas.tsx): fix SeveritiesMetaText rendering and translation issue
🔨 refactor(Metas.tsx): remove unused imports and variables
UTT-66-playlist-fixes
Utt 35 pip player
refactor(PageHeader.tsx): improve usecase name and device display in …
…e usecase descriptions
…ultExpandedSections prop
🔨 refactor(Player.tsx): remove unnecessary setIsPlaying and video play calls
FIX(Player.tsx): decrease z-index value from 101 to 3 for better layering
FIX(ObservationTooltip.tsx): fix seekPlayer function call duplication
FIX(VideosPageContent.tsx): set UC-Accordions close as default
FIX(InfoRow.tsx): remove uc description in accordion
FIX:(PageHeader.tsx): improve usecase name and device display in Page…
sinatragianpaolo
commented
Jul 4, 2024
sinatragianpaolo
commented
Jul 4, 2024
sinatragianpaolo
commented
Jul 4, 2024
fixed unused pieces of code
iDome89
approved these changes
Jul 4, 2024
cannarocks
approved these changes
Jul 4, 2024
Member
cannarocks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No description provided.