Improve player and transcript usability #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the dependency on @appquality/unguess-design-system from version 3.1.101 to version 3.1.102 in the package.json file. This update includes bug fixes and improvements to the design system. It is important to keep our dependencies up to date to ensure compatibility and take advantage of the latest features and fixes.
This commit updates the video player URL handling in the `Player.tsx` component. Instead of directly using `video.url`, the code now checks if `video.streamUrl` is available and uses it as the URL if present, falling back to `video.url` otherwise. This change improves the flexibility of the video player and allows for better integration with different video sources. Additionally, a play button has been added to the transcript in the `ParagraphMeta.tsx` component. Clicking the play button will set the current time of the video to the start time of the corresponding paragraph. Note: This suggested commit message follows the established convention of using a prefix (feat) to indicate a new feature or enhancement.
cannarocks
changed the title
iDome89
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update @appquality/unguess-design-system dependency to v3.1.102
This pull request updates the dependency on @appquality/unguess-design-system from version 3.1.101 to version 3.1.102 in the package.json file. The update includes bug fixes and improvements to the design system. Keeping our dependencies up to date ensures compatibility and allows us to take advantage of the latest features and fixes
Update video player URL handling and add play button to transcript
This pull request updates the video player URL handling in the
Player.tsxcomponent. Instead of directly usingvideo.url, the code now checks ifvideo.streamUrlis available and uses it as the URL if present, falling back tovideo.urlotherwise. This change improves the flexibility of the video player and allows for better integration with different video sources.Additionally, a play button has been added to the transcript in the
ParagraphMeta.tsxcomponent. Clicking the play button will set the current time of the video to the start time of the corresponding paragraph.