Develop #541
Merged
Develop #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ feat(Tags.tsx): add ability to create new tags 🔥 chore(useBugDetail.ts): remove unused file 🔧 chore(apiTags.ts): change invalidation tag from 'Tags' to 'Bugs' 🎨 style(BugPreview.tsx): add refetchOnMountOrArgChange to useGetCampaignsByCidBugsAndBidQuery() call 🐛 fix(PageHeader/Tools): useCampaign -> useCampaignBugs ✨ feat(PageHeader/Tools): add useCampaignBugs hook to fetch campaign bugs data
💄 style(Tags.tsx): add eslint-disable-next-line to console.error line
fix(bugs-list): change filters buttons sizes
UN-749-moving-dropdown
Un 535 rtk cache
Recreate design system AppHeader in react
fix(bugs-table): behavior of long use cases
…ng on it ✨ feat(FilterRecap.tsx): add custom status to filter recap and remove it when clicking on it
…atusInfo 🔀 chore(BugsTable): rename getBugStateLabel to getCustomStatusInfo 🔀 chore(types.d.ts): remove unused BugState type definition ✨ feat(BugStateDropdown.tsx): use getCustomStatusInfo instead of getBugStateLabel ✨ feat(BugsTable): use getCustomStatusInfo instead of getBugStateLabel ✨ feat(translation.json): remove unused translations for bug states
…ainer when isFetching is true 🐛 fix(BugPreview.tsx): remove isFetching from the condition to render Skeleton component
…tCampaignsByCidBugsAndBidQuery hook
…r bug statuses and filters
✨ feat(SortBy.tsx): add translation support for sort by labels and refactor to use redux state instead of local state
✨ feat(OrderBy.tsx): add translation support for dropdown items
🔥 refactor(types.d.ts): remove unused OrderSelection type 🚀 chore(bugsPageSlice.ts): remove commented code 🚀 chore(CustomStatusField.tsx): remove commented code and unused imports
UN-795-custom-status-accordion
fix status icon alignment
fix(bugs-table): sort statuses
…ed on isLightbox prop ✨ feat(lightbox.tsx): pass isLightbox prop to DetailsItems component
🎨 style(DetailsItems.tsx): conditionally render BugTags component based on isLightbox prop
New Crowdin updates
New Crowdin updates
…y to Separator component 🎨 style(BugStateDropdown.tsx): change map function parameter name from i to item for clarity 🎨 style(BugStateDropdown.tsx): add space between curly braces and ternary operator in map function
cannarocks
reviewed
Apr 12, 2023
| container: responsive-container / inline-size; | ||
| } | ||
|
|
||
| @container responsive-container (width > 576px) { |
Member
There was a problem hiding this comment.
Ma usare una variabile del tema al posto di quel 576? così se un domani dovessimo cambiare i nostri breakpoint non serve andare a modificare pure questi cssoni
Member
There was a problem hiding this comment.
Capisco che è un pochino scomodo andare di css variables, ma si può impostare fino a quando non potremo usare la versione aggiornata di styled components. PER LA RELEASE IMMINENTE VA BENE PURE COSI'
| parameters: { | ||
| path: { | ||
| /** Campaign id */ | ||
| cid: string; |
Member
There was a problem hiding this comment.
non dovrebbe usare il parametro globale cid?
🐛 fix(BugStateDropdown.tsx): fix key prop warning by adding unique key to Separator component
cannarocks
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.