-
Notifications
You must be signed in to change notification settings - Fork 1
UN-795-custom-status-accordion #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handle excluding not a bug
…andle to show custom bug status
…tate with BugState
…ses in useCampaignBugs hook
…d code 🐛 fix(CustomStatusField.tsx): fix disabled state of checkboxes based on counters
…ng on it ✨ feat(FilterRecap.tsx): add custom status to filter recap and remove it when clicking on it
…atusInfo 🔀 chore(BugsTable): rename getBugStateLabel to getCustomStatusInfo 🔀 chore(types.d.ts): remove unused BugState type definition ✨ feat(BugStateDropdown.tsx): use getCustomStatusInfo instead of getBugStateLabel ✨ feat(BugsTable): use getCustomStatusInfo instead of getBugStateLabel ✨ feat(translation.json): remove unused translations for bug states
7b182e9 to
29c13ce
Compare
…ainer when isFetching is true 🐛 fix(BugPreview.tsx): remove isFetching from the condition to render Skeleton component
…tCampaignsByCidBugsAndBidQuery hook
…r bug statuses and filters
✨ feat(SortBy.tsx): add translation support for sort by labels and refactor to use redux state instead of local state
✨ feat(OrderBy.tsx): add translation support for dropdown items
🔥 refactor(types.d.ts): remove unused OrderSelection type 🚀 chore(bugsPageSlice.ts): remove commented code 🚀 chore(CustomStatusField.tsx): remove commented code and unused imports
marcbon
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
This pull request also implements UN-801-Quick Filter (exclude "not a bug" Toggle)