Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentError (invalid byte sequence in UTF-8) #736 #737

Closed
wants to merge 28 commits into from
Closed

ArgumentError (invalid byte sequence in UTF-8) #736 #737

wants to merge 28 commits into from

Conversation

aussiDavid
Copy link
Contributor

#736 ArgumentError (invalid byte sequence in UTF-8). Remove invalid characters when parsing the file handler path.

hank-spokeo and others added 10 commits March 17, 2021 00:25
This fixes the following warnings that are printed when using this gem with Ruby 2.7.1:

```
/root/project/vendor/bundle/ruby/2.7.0/gems/apipie-rails-0.5.18/lib/apipie/extractor/recorder.rb:154: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/root/project/vendor/bundle/ruby/2.7.0/gems/actionpack-6.0.3.1/lib/action_controller/test_case.rb:460: warning: The called method `process' is defined here
```
…haracters when parsing the file handler path
Fixes doc comment
@aussiDavid
Copy link
Contributor Author

Hi @Pajk and @iNecas, any chance in nudging this along? Do you need anything in particular checked?

@mathieujobin
Copy link
Collaborator

@aussiDavid Can you rebase your branch so the tests run ?

Thanks

…haracters when parsing the file handler path
@aussiDavid
Copy link
Contributor Author

@mathieujobin Done.

@mathieujobin
Copy link
Collaborator

Merci David.

@ofedoren
Copy link
Contributor

This rebase looks wierd, won't this mess up the already messed up history? :)

Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to properly rebase, there has been a mix of merge and rebase, causing duplicate commits to be shown...

@aussiDavid
Copy link
Contributor Author

I was unable to fix the rebasing. I've redone the pull request here #746

@aussiDavid aussiDavid closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants