Deprecate Travis, run tests on GitHub Actions #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofedoren mind reviewing this? |
mathieujobin
commented
Feb 24, 2022
| - 2.7.0 | ||
| gemfile: | ||
| - Gemfile.rails42 | ||
| - Gemfile.rails51 # Min ruby 2.2.2 |
There was a problem hiding this comment.
Note that 4.1 and 5.0 was not running on CI before this change..
ofedoren
reviewed
Feb 25, 2022
| @@ -0,0 +1,160 @@ | |||
| PATH | |||
There was a problem hiding this comment.
Why do we need to have this lock file?
There was a problem hiding this comment.
Simply to force Github Actions to select Bundler 1.17.3
this is required for Rails 4.2 tests to run on Github Actions. or at least, its the best solution I found that I use for many gems.
we can delete once we decide to drop Rails 4.2 from the test suite.
ofedoren
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing with ruby 3.0 (should be a different PR, but I don't think I'll invest the time soon)
someone else can take it.