feat!: sourcemap repr, str, docs and fixes
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Feb 2, 2023
Comment on lines
+177
to
+178
| def __str__(self) -> str: | ||
| return self.__root__ |
There was a problem hiding this comment.
Isn't this the default __str__ method output if __repr__ is defined?
There was a problem hiding this comment.
It didn't seem like it. I added the test before I added this and it would fail at first and give me this:
SourceMap(__root__"<realsourcemap>")
There was a problem hiding this comment.
where realsourcemap was the real source map
There was a problem hiding this comment.
If I comment out def __str__, I get this:
assert "__root__='44...441:16;;;;;;'" == '449:4441:16:...4441:16;;;;;;'
so it is __root__='44...441:16;;;;;;'.
Does overriding __str__ here cause any issues I am not yet aware of?
4 tasks
|
This diff will be better once this merges #59 |
antazoey
changed the title
sourcemap repr and str as well as documentation improvementsourcemap repr, str, docs and fixes
antazoey
force-pushed
the
feat/sourcemap-repr
branch
from
91f7126
to
7fc613e
Compare
NotPeopling2day
previously approved these changes
Feb 2, 2023
ghost
previously approved these changes
Feb 3, 2023
Co-authored-by: NotPeopling2day <32708219+NotPeopling2day@users.noreply.github.com>
ghost
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did and How I Did It
My main goal here is trying to understand, so if you review this PR, please make help me do so!
So I noticed that
__repr__forSourceMaplooked funny, so I starting poking in that. I foundSourceMapItemand theparse()method so wanted to know more about how that worked because the docs were sort of missing.__repr__implementation toSourceMap__str__implementation toSourceMapSourceMapItemstoptolengthinSourceMapItemfixes: APE-581
How to verify it
Checklist