feat: add sourcemap to ContractType output
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Feb 2, 2023
| def test_source_map(project, compiler): | ||
| source_path = project.contracts_folder / "MultipleDefinitions.sol" | ||
| result = compiler.compile([source_path])[-1] | ||
| assert result.sourcemap.__root__ == "124:87:0:-:0;;;;;;;;;;;;;;;;;;;" |
There was a problem hiding this comment.
Can make this test nicer if ApeWorX/ethpm-types#58 merges + releases
NotPeopling2day
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
srcmapoutput.This stemmed from using Solidity docs to understand Vyper more, regarding
sourcemap. However, I wanted to see this part work in Solidity to cross-compare and follow the docs. This is mostly part of my research into building coverage features in Ape.Question: not sure we would want to merge this until we know we will be using this? That is fine if that is the case. I am mostly focused on Vyper right now, as is the plan.
fixes: APE-582
How I did it
Found the output
srcmapthat gives the source map similarly topc_pos_map_compressedin Vyper.Is this correct?
How to verify it
Checklist