-
Notifications
You must be signed in to change notification settings - Fork 33
SC: Implement get_call_data, set_call_return_value and get_call_data host functions
#1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…put from the calling action
|
afaict we aren't enforcing |
I plan to enforce |
spoonincode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have missed it, but I think it would be worthwhile to have tests that have a 0 length call data, and 0 length call return data.
Also I see we're following the same pattern as action return data that makes it impossible to discern between an action that returned nothing and an action that returned a 0 length value. Consistency is good; just pointing it out.
Good idea! I added #1297 for more tests in a future PR. Right now I have |
This PR implements the remaining sync call host functions. Basic sync call protocol level functionalities are in place.
Unit test
basic_params_return_value_passingshows a complete end to end sync call in WASM code using the host functions in the following stepsResolves #1215