SC: Add destructor to wasm_allocator to release memory #39
Conversation
include/eosio/vm/allocator.hpp
Outdated
| page = 0; | ||
| } | ||
| ~wasm_allocator() { | ||
| if (raw) { |
There was a problem hiding this comment.
Isn't there a problem if free() is called and something else mmap into the same old raw location. This could free some other mmap. Seems like free() should set raw = nullptr.
There was a problem hiding this comment.
I wonder if making free() private would be the way to go here. Seems like that or you need to sprinkle in some EOS_VM_ASSERT(raw, wasm_bad_alloc, "already freed"); and set raw = nullptr inside free().
There was a problem hiding this comment.
I am afraid that modifying free() or making it private might break some existing uses (although Spring does not use free directly).
There was a problem hiding this comment.
I wonder if making
free()private would be the way to go here
or just rename free() as the dtor? free() isn't used anywhere
There was a problem hiding this comment.
Thank both of you. I renamed free to the destructor.
spoonincode
left a comment
spoonincode
left a comment
There was a problem hiding this comment.
whoops didn't mean to dismiss, seems fine
Change Description
wasm_allocatordid not implement destructors, and memory it allocated was not released. It caused memory exhaustion when running unit_test.The PR adds a destructor to free the memory.
I re-run
unit_testwith this change and was able to run to the completion.Resolves AntelopeIO/spring#1407
API Changes
Documentation Additions